Detect Chrome from Samsung devices. Closes fnando#107.

Author: fnando

lib/browser.rb

@@ -42,9 +42,9 @@ class Browser
  alias_method :ua=, :user_agent=
 
  NAMES = {
+ chrome: "Chrome", # Must come before android
  android: "Android",
  blackberry: "BlackBerry",
- chrome: "Chrome",
  core_media: "Apple CoreMedia",
  firefox: "Firefox",
  ie: "Internet Explorer",
@@ -65,7 +65,8 @@ class Browser
  }
 
  VERSIONS = {
- default: %r[(?:Version|MSIE|Firefox|Chrome|CriOS|QuickTime|BlackBerry[^/]+|CoreMedia v|PhantomJS)[/ ]?([a-z0-9.]+)]i,
+ chrome: %r[(?:Chrome|CriOS)/([\d.]+)],
+ default: %r[(?:Version|MSIE|Firefox|QuickTime|BlackBerry[^/]+|CoreMedia v|PhantomJS)[/ ]?([a-z0-9.]+)]i,
  opera: %r[(?:Opera/.*? Version/([\d.]+)|Chrome/([\d.]+).*?OPR)],
  ie: %r[(?:MSIE |Trident/.*?; rv:)([\d.]+)]
  }

test/browser_spec.rb

@@ -308,6 +308,19 @@
  assert_equal "19", @browser.version
  end
 
+ it "detects samsung chrome" do
+ @browser.ua = $ua["SAMSUNG_CHROME"]
+
+ assert_equal "Chrome", @browser.name
+ assert @browser.chrome?
+ assert @browser.android?
+ refute @browser.safari?
+ assert @browser.webkit?
+ assert @browser.modern?
+ assert_equal "28.0.1500.94", @browser.full_version
+ assert_equal "28", @browser.version
+ end
+
  it "detects android" do
  @browser.ua = $ua["ANDROID"]
 

test/ua.yml

@@ -37,6 +37,7 @@ XOOM: "Mozilla/5.0 (Linux; U; Android 3.0; en-us; Xoom Build/HRI39) AppleWebKit/
 NEXUS_TABLET: "Mozilla/5.0 (Linux; Android 4.1.1; Nexus 7 Build/JRO03D) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Safari/535.19"
 NOOK: "Mozilla/5.0 (Linux; U; Android 2.3.4; en-us; NOOK BNTV250A Build/GINGERBREAD 1.4.3) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Safari/533.1"
 SAMSUNG: "Mozilla/5.0 (Linux; U; Android 4.0.4; en-us; SAMSUNG-SGH-I497 Build/IMM76D) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30"
+SAMSUNG_CHROME: "Mozilla/5.0 (Linux; Android 4.4.2; en-gb; SAMSUNG GT-I9195/I9195XXUCNEA Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Version/1.5 Chrome/28.0.1500.94 Mobile Safari/537.36"
 OPERA_MINI: "Opera/9.80 (Android; Opera Mini/7.029952/28.2359;u; fr) Presto/2.8.119 Version/11.10"
 OPERA_MOBI: "Opera/9.8 (Android 2.3.5; Linux; Opera Mobi/ADR-1205181138; U; en) Presto/2.10.254 Version/12.00"
 WINDOWS_PHONE: "Mozilla/4.0 (compatible; MSIE 7.0; Windows Phone OS 7.0; Trident/3.1; IEMobile/7.0; DELL; Venue Pro)"