Skip to content

Commit 002e85e

Browse files
committed
Don't recognize Android as Safari.
1 parent a530226 commit 002e85e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/browser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def phantom_js?
156156

157157
# Detect if browser is Safari.
158158
def safari?
159-
ua =~ /Safari/ && ua !~ /Chrome|CriOS|PhantomJS/
159+
ua =~ /Safari/ && ua !~ /Android|Chrome|CriOS|PhantomJS/
160160
end
161161

162162
# Detect if browser is Firefox.

test/browser_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@
313313

314314
assert_equal "Android", @browser.name
315315
assert @browser.android?
316-
assert @browser.safari?
316+
refute @browser.safari?
317317
assert @browser.webkit?
318318
assert @browser.mobile?
319319
refute @browser.tablet?
@@ -327,7 +327,7 @@
327327

328328
assert_equal "Android", @browser.name
329329
assert @browser.android?
330-
assert @browser.safari?
330+
refute @browser.safari?
331331
assert @browser.webkit?
332332
refute @browser.mobile?
333333
assert @browser.tablet?

0 commit comments

Comments
 (0)