fix: API edit mutation could fail because of incorrect check of arguments

* fixed graphql endpoint not accept empty after edited * removed console logs * improve API configuration edit mutation --------- Co-authored-by: Antoine Hurard <antoine.reliefapps@gmail.com>

Author: RenzoPrats

src/i18n/en.json

@@ -67,7 +67,7 @@
 },
 "edit": {
 "errors": {
-"invalidArguments": "Either name, status, authType, endpoint, pingUrl, settings or permissions must be provided."
+"invalidArguments": "Either name, status, authType, endpoint, graphqlEndpoint, pingUrl, settings or permissions must be provided."
 }
 }
 },

src/schema/mutation/editApiConfiguration.mutation.ts

@@ -14,6 +14,7 @@ import { buildTypes } from '@utils/schema';
 import { validateApi } from '@utils/validators/validateApi';
 import config from 'config';
 import { logger } from '@services/logger.service';
+import { cloneDeep, isEmpty, omit } from 'lodash';
 
 /**
  * Edit the passed apiConfiguration if authorized.
@@ -41,42 +42,33 @@ export default {
  );
  }
  const ability: AppAbility = user.ability;
- if (
- !args.name &&
- !args.status &&
- !args.authType &&
- !args.endpoint &&
- !args.pingUrl &&
- !args.graphQLEndpoint &&
- !args.settings &&
- !args.permissions
- ) {
+
+ // Check if any of required arguments for a valid update are provided.
+ // Else, send error
+ // cloneDeep coupled with omit allows to filter out the 'id' field
+ if (isEmpty(cloneDeep(omit(args, ['id'])))) {
  throw new GraphQLError(
  context.i18next.t(
  'mutations.apiConfiguration.edit.errors.invalidArguments'
  )
  );
  }
- const update = {};
+ // See if API name is usable
  if (args.name) {
  validateApi(args.name);
  }
- Object.assign(
- update,
- args.name && { name: args.name },
- args.status && { status: args.status },
- args.authType && { authType: args.authType },
- args.endpoint && { endpoint: args.endpoint },
- args.graphQLEndpoint && { graphQLEndpoint: args.graphQLEndpoint },
- args.pingUrl && { pingUrl: args.pingUrl },
- args.settings && {
+ // Create the update document
+ const update = {
+ ...cloneDeep(omit(args, ['id'])),
+ ...(args.settings && {
  settings: CryptoJS.AES.encrypt(
  JSON.stringify(args.settings),
  config.get('encryption.key')
  ).toString(),
- },
- args.permissions && { permissions: args.permissions }
- );
+ }),
+ };
+
+ // Find API configuration and update it using User permissions
  const filters = ApiConfiguration.accessibleBy(ability, 'update')
  .where({ _id: args.id })
  .getFilter();