fix: number question values, when saved as string, would not match in filters (#774)

* fixed number filter is not considering string numbers * lint fixed --------- Co-authored-by: Antoine Hurard <antoine.reliefapps@gmail.com>

Author: RenzoPrats

src/utils/filter/getFilter.ts

@@ -79,7 +79,8 @@ const buildMongoFilter = (filter: any, fields: any[]): any => {
  } else {
  return {
  $or: [
- { [fieldName]: { $eq: value } },
+ // Make sure that we check on number & string values
+ { [fieldName]: { $eq: String(value) } },
  { [fieldName]: { $eq: intValue } },
  ],
  };
@@ -97,7 +98,7 @@ const buildMongoFilter = (filter: any, fields: any[]): any => {
  } else {
  return {
  $or: [
- { [fieldName]: { $ne: value } },
+ { [fieldName]: { $ne: String(value) } },
  { [fieldName]: { $ne: intValue } },
  ],
  };
@@ -121,7 +122,7 @@ const buildMongoFilter = (filter: any, fields: any[]): any => {
  } else {
  return {
  $or: [
- { [fieldName]: { $lt: value } },
+ { [fieldName]: { $lt: String(value) } },
  { [fieldName]: { $lt: intValue } },
  ],
  };
@@ -133,7 +134,7 @@ const buildMongoFilter = (filter: any, fields: any[]): any => {
  } else {
  return {
  $or: [
- { [fieldName]: { $lte: value } },
+ { [fieldName]: { $lte: String(value) } },
  { [fieldName]: { $lte: intValue } },
  ],
  };
@@ -145,7 +146,7 @@ const buildMongoFilter = (filter: any, fields: any[]): any => {
  } else {
  return {
  $or: [
- { [fieldName]: { $gt: value } },
+ { [fieldName]: { $gt: String(value) } },
  { [fieldName]: { $gt: intValue } },
  ],
  };
@@ -157,7 +158,7 @@ const buildMongoFilter = (filter: any, fields: any[]): any => {
  } else {
  return {
  $or: [
- { [fieldName]: { $gte: value } },
+ { [fieldName]: { $gte: String(value) } },
  { [fieldName]: { $gte: intValue } },
  ],
  };

src/utils/schema/resolvers/Query/getFilter.ts

@@ -241,7 +241,8 @@ const buildMongoFilter = (
  } else {
  return {
  $or: [
- { [fieldName]: { $eq: value } },
+ // Make sure that we compare both strings & numbers
+ { [fieldName]: { $eq: String(value) } },
  { [fieldName]: { $eq: intValue } },
  ],
  };
@@ -262,7 +263,7 @@ const buildMongoFilter = (
  } else {
  return {
  $and: [
- { [fieldName]: { $ne: value } },
+ { [fieldName]: { $ne: String(value) } },
  { [fieldName]: { $ne: intValue } },
  ],
  };
@@ -286,7 +287,7 @@ const buildMongoFilter = (
  } else {
  return {
  $or: [
- { [fieldName]: { $lt: value } },
+ { [fieldName]: { $lt: String(value) } },
  { [fieldName]: { $lt: intValue } },
  ],
  };
@@ -298,7 +299,7 @@ const buildMongoFilter = (
  } else {
  return {
  $or: [
- { [fieldName]: { $lte: value } },
+ { [fieldName]: { $lte: String(value) } },
  { [fieldName]: { $lte: intValue } },
  ],
  };
@@ -310,7 +311,7 @@ const buildMongoFilter = (
  } else {
  return {
  $or: [
- { [fieldName]: { $gt: value } },
+ { [fieldName]: { $gt: String(value) } },
  { [fieldName]: { $gt: intValue } },
  ],
  };
@@ -322,7 +323,7 @@ const buildMongoFilter = (
  } else {
  return {
  $or: [
- { [fieldName]: { $gte: value } },
+ { [fieldName]: { $gte: String(value) } },
  { [fieldName]: { $gte: intValue } },
  ],
  };