fix code complexity (from ci reports)

Author: b-richard

src/Command/DumpJsConfig.php

@@ -13,6 +13,12 @@
 
 class DumpJsConfig extends ContainerAwareCommand
 {
+ const ARG_HOST = 'host';
+
+ const ARG_PORT = 'port';
+
+ const ARG_QUASAR_STYLE = 'quasarStyle';
+
  /**
  * @var \Twig_Environment
  */
@@ -84,9 +90,9 @@ protected function configure()
  ->setName('app:dump-js-config')
  ->setDescription('Create the config.js file.')
  ->setHelp('Dump symfony configuration into a config.js file available from assets/js/*')
- ->addArgument('host', InputArgument::OPTIONAL, 'The full hostname of the web-server.', 'localhost')
- ->addArgument('port', InputArgument::OPTIONAL, 'The port for the web-server.', '80')
- ->addArgument('quasarStyle', InputArgument::OPTIONAL, 'The style for quasar framework: mat or ios.', 'mat');
+ ->addArgument(self::ARG_HOST, InputArgument::OPTIONAL, 'The full hostname of the web-server.', 'localhost')
+ ->addArgument(self::ARG_PORT, InputArgument::OPTIONAL, 'The port for the web-server.', '80')
+ ->addArgument(self::ARG_QUASAR_STYLE, InputArgument::OPTIONAL, 'The style for quasar framework: mat or ios.', 'mat');
  }
 
  /**
@@ -100,9 +106,9 @@ protected function configure()
  protected function execute(InputInterface $input, OutputInterface $output)
  {
  $env = $this->getEnv();
- $host = $input->getArgument('host');
- $port = $input->getArgument('port');
- $quasarStyle = $input->getArgument('quasarStyle');
+ $host = $input->getArgument(self::ARG_HOST);
+ $port = $input->getArgument(self::ARG_PORT);
+ $quasarStyle = $input->getArgument(self::ARG_QUASAR_STYLE);
 
  if (!$this->validateInputs($output, $port, $quasarStyle)) {
  return;
@@ -118,6 +124,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
  }
 
  /**
+ * @param OutputInterface $output
  * @return array
  */
  protected function loadApiPlatformConfig(OutputInterface $output): array
@@ -129,21 +136,23 @@ protected function loadApiPlatformConfig(OutputInterface $output): array
  $values = Yaml::parseFile($configDir . 'packages/api_platform.yaml');
  $config = $values['api_platform'];
 
- if ($config['collection'] && $config['collection']['pagination']) {
- foreach ($mandatoryKeys as $key) {
- if (!array_key_exists($key, $config['collection']['pagination'])) {
- $missingKeys[] = $key;
- }
- }
+ if (!($config['collection'] && $config['collection']['pagination'])) {
+ throw new \Exception('Missing pagination section in api_platform.yaml');
+ }
 
- if (count($missingKeys)) {
- throw new \Exception(sprintf('those keys are mandatory for the frontend configuration: %s', join(', ', $missingKeys)));
+ foreach ($mandatoryKeys as $key) {
+ if (array_key_exists($key, $config['collection']['pagination'])) {
+ continue;
  }
 
- return $config['collection']['pagination'];
+ $missingKeys[] = $key;
+ }
+
+ if (count($missingKeys)) {
+ throw new \Exception(sprintf('those keys are mandatory for the frontend configuration: %s', join(', ', $missingKeys)));
  }
 
- throw new \Exception('Missing pagination section in api_platform.yaml');
+ return $config['collection']['pagination'];
  } catch (\Exception $e) {
  $output->writeln(sprintf('api_platform.yaml error: "%s"', $e->getMessage()));
  }
@@ -177,15 +186,15 @@ protected function validateInputs(OutputInterface $output, $port, $quasarStyle):
  $validator = Validation::createValidator();
  $violations = [];
 
- $violations['port'] = $validator->validate($port, [
+ $violations[self::ARG_PORT] = $validator->validate($port, [
  new Assert\Type(['type' => 'numeric', ]),
  ]);
 
- $violations['quasarStyle'] = $validator->validate($quasarStyle, [
+ $violations[self::ARG_QUASAR_STYLE] = $validator->validate($quasarStyle, [
  new Assert\Choice(['choices' => ['mat', 'ios'], ]),
  ]);
 
- if (0 !== count($violations['port']) && 0 !== count($violations['quasarstyle'])) {
+ if (0 !== count($violations[self::ARG_PORT]) && 0 !== count($violations[self::ARG_QUASAR_STYLE])) {
  $output->writeln([
  'Params errors',
  '=======================', ]);

src/DataFixtures/Library/AppFixtures.php

@@ -190,6 +190,35 @@ protected function addEditor($bookFixture, Book $book, Connection $dbh, ObjectMa
  * @throws \Doctrine\DBAL\DBALException
  */
  protected function addAuthor($bookFixture, Book $book, Connection $dbh, ObjectManager $manager)
+ {
+ $rows = $this->getAuthorsInfo($bookFixture, $dbh);
+
+ if (!count($rows)) {
+ return;
+ }
+
+ $i = 0;
+ foreach ($rows as $row) {
+ $authorName = explode('| ', $row['name']);
+ if (!in_array($row['id'], $this->cache['authors'])) {
+ $author = $this->getNewAuthor($manager, $authorName, $row);
+ } else {
+ $author = $this->getExistingAuthor($manager, $authorName);
+ }
+
+ $this->attachAuthorToBook($book, $author, $i);
+
+ $i++;
+ }
+ }
+
+ /**
+ * @param $bookFixture
+ * @param Connection $dbh
+ * @return array
+ * @throws \Doctrine\DBAL\DBALException
+ */
+ protected function getAuthorsInfo($bookFixture, Connection $dbh): array
  {
  $bookId = $bookFixture['id'];
 
@@ -206,41 +235,59 @@ protected function addAuthor($bookFixture, Book $book, Connection $dbh, ObjectMa
  $sth->bindParam('bookId', $bookId, PDO::PARAM_INT);
  $sth->execute();
  $rows = $sth->fetchAll();
+ return $rows;
+ }
 
- if (count($rows)) {
- $i = 0;
- foreach ($rows as $row) {
- $authorName = explode('| ', $row['name']);
- if (!in_array($row['id'], $this->cache['authors'])) {
- $author = new Author();
- if (2 === count($authorName)) {
- $author->setFirstname($authorName[0])
- ->setLastname($authorName[1]);
- } else {
- $author->setFirstname($authorName[0]);
- }
-
- $manager->persist($author);
-
- $this->cache['authors'][] = $row['id'];
- } else {
- $criterias = ['firstname' => $authorName[0], 'lastname' => null, ];
- if (2 === count($authorName)) {
- $criterias['lastname'] = $authorName[1];
- }
- $author = $manager
- ->getRepository('\\App\\Entity\\Library\\Author')
- ->findOneBy($criterias);
- }
-
- $job = $this->cache['jobs'][0];
- if (1 === $i) {
- $job = $this->cache['jobs'][0];
- }
- $book->addAuthor($author, $job);
-
- $i++;
- }
+ /**
+ * @param ObjectManager $manager
+ * @param $authorName
+ * @param $row
+ * @return Author
+ */
+ protected function getNewAuthor(ObjectManager $manager, $authorName, $row): Author
+ {
+ $author = new Author();
+ if (2 === count($authorName)) {
+ $author->setFirstname($authorName[0])
+ ->setLastname($authorName[1]);
+ } else {
+ $author->setFirstname($authorName[0]);
+ }
+
+ $manager->persist($author);
+
+ $this->cache['authors'][] = $row['id'];
+ return $author;
+ }
+
+ /**
+ * @param ObjectManager $manager
+ * @param $authorName
+ * @return null|object
+ */
+ protected function getExistingAuthor(ObjectManager $manager, $authorName)
+ {
+ $criterias = ['firstname' => $authorName[0], 'lastname' => null,];
+ if (2 === count($authorName)) {
+ $criterias['lastname'] = $authorName[1];
+ }
+ $author = $manager
+ ->getRepository('\\App\\Entity\\Library\\Author')
+ ->findOneBy($criterias);
+ return $author;
+ }
+
+ /**
+ * @param Book $book
+ * @param $author
+ * @param $i
+ */
+ protected function attachAuthorToBook(Book $book, $author, $i): void
+ {
+ $job = $this->cache['jobs'][0];
+ if (1 === $i) {
+ $job = $this->cache['jobs'][0];
  }
+ $book->addAuthor($author, $job);
  }
 }

src/Security/CsrfTokenAuthenticator.php

@@ -1,6 +1,7 @@
 <?php
 namespace App\Security;
 
+use http\Exception\RuntimeException;
 use Psr\Container\ContainerInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\JsonResponse;
@@ -148,20 +149,22 @@ public function supports(Request $request)
  public function getCredentials(Request $request)
  {
  // for GET Method
- if (strtolower($request->getMethod()) !== 'get') {
- // for other Methods, then there must be a body HTTP with JSON content
- $content = json_decode($request->getContent());
- if (is_null($content)) {
- if (json_last_error()) {
- throw new AuthenticationException('Json format: ' . json_last_error_msg(), 420);
- }
+ if (strtolower($request->getMethod()) === 'get') {
+ throw new RuntimeException('Should not be here when method is get, check the CLASS::supports methods');
+ }
 
- $content = [];
+ // for other Methods, then there must be a body HTTP with JSON content
+ $content = json_decode($request->getContent());
+ if (is_null($content)) {
+ if (json_last_error()) {
+ throw new AuthenticationException('Json format: ' . json_last_error_msg(), 420);
  }
 
- $json = new \ArrayObject($content, \ArrayObject::STD_PROP_LIST);
+ $content = [];
  }
 
+ $json = new \ArrayObject($content, \ArrayObject::STD_PROP_LIST);
+
  if (!isset($json[$this->csrfTokenParameter])) {
  throw new AuthenticationException($this->csrfTokenParameter . ' mandatory', 420);
  }
@@ -173,21 +176,14 @@ public function getCredentials(Request $request)
  );
  }
 
- if (!isset($json[$this->loginUsernamePath])) {
- throw new AuthenticationException($this->loginUsernamePath . ' mandatory', 420);
- }
-
- if (!isset($json[$this->loginPasswordPath])) {
- throw new AuthenticationException($this->loginPasswordPath . ' mandatory', 420);
- }
-
- return array(
- 'token' => $json[$this->csrfTokenParameter],
- 'username' => $json[$this->loginUsernamePath],
- 'password' => $json[$this->loginPasswordPath]
- );
+ return $this->checkAndBuildFullCredentials($json);
  }
 
+ /**
+ * @param mixed $credentials
+ * @param UserProviderInterface $userProvider
+ * @return mixed|null|UserInterface
+ */
  public function getUser($credentials, UserProviderInterface $userProvider)
  {
  if (false === $this->csrfTokenManager->isTokenValid(new SymfonyCsrfToken($this->csrfTokenId, $credentials['token']))) {
@@ -216,6 +212,11 @@ public function getUser($credentials, UserProviderInterface $userProvider)
  }
  }
 
+ /**
+ * @param mixed $credentials
+ * @param UserInterface $user
+ * @return bool
+ */
  public function checkCredentials($credentials, UserInterface $user)
  {
  // The CsrfTokenAuthenticator has just been used to validate csrf token on non GET route
@@ -230,12 +231,23 @@ public function checkCredentials($credentials, UserInterface $user)
  return true;
  }
 
+ /**
+ * @param Request $request
+ * @param TokenInterface $token
+ * @param string $providerKey
+ * @return null|Response
+ */
  public function onAuthenticationSuccess(Request $request, TokenInterface $token, $providerKey)
  {
  // on success, let the request continue
  return null;
  }
 
+ /**
+ * @param Request $request
+ * @param AuthenticationException $exception
+ * @return null|JsonResponse|Response
+ */
  public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
  {
  $message = $exception->getMessage() ? $exception->getMessage() : strtr($exception->getMessageKey(), $exception->getMessageData());
@@ -265,8 +277,32 @@ public function start(Request $request, AuthenticationException $authException =
  return new JsonResponse($data, Response::HTTP_UNAUTHORIZED);
  }
 
+ /**
+ * @return bool
+ */
  public function supportsRememberMe()
  {
  return false;
  }
+
+ /**
+ * @param $json
+ * @return array
+ */
+ protected function checkAndBuildFullCredentials($json): array
+ {
+ if (!isset($json[$this->loginUsernamePath])) {
+ throw new AuthenticationException($this->loginUsernamePath . ' mandatory', 420);
+ }
+
+ if (!isset($json[$this->loginPasswordPath])) {
+ throw new AuthenticationException($this->loginPasswordPath . ' mandatory', 420);
+ }
+
+ return array(
+ 'token' => $json[$this->csrfTokenParameter],
+ 'username' => $json[$this->loginUsernamePath],
+ 'password' => $json[$this->loginPasswordPath]
+ );
+ }
 }