woups fix regression on JWT token generation

Author: b-richard

src/Security/JwtTokenTools.php

@@ -21,7 +21,7 @@ class JwtTokenTools
  * @param $password
  * @param LoggerInterface|null $logger
  * @return string
- * @throws \Exception
+ * @throws \Lexik\Bundle\JWTAuthenticationBundle\Exception\JWTEncodeFailureException
  */
  public function encodeToken(
  InMemoryUserProvider $provider,
@@ -35,33 +35,26 @@ public function encodeToken(
  try {
  $user = $provider->loadUserByUsername($username);
 
- if (!isset($user)) {
- throw new NotFoundHttpException();
- }
-
  $isValid = $passwordEncoder
  ->isPasswordValid($user, $password);
 
  if (!$isValid) {
  throw new BadCredentialsException();
  }
 
- return $encoder->encode([
+ $token = $encoder->encode([
  'username' => $username,
  'exp' => time() * $tokenJwtTtl
  ]);
- } catch (UsernameNotFoundException $e) {
- if ($logger) {
- $logger->alert(sprintf('Exception: UsernameNotFoundException: %s', $e->getMessage()));
- }
 
- throw $e;
- } catch (BadCredentialsException $e) {
+ return $token;
+ } catch (UsernameNotFoundException $e) {
+ $msg = sprintf('Exception: UsernameNotFoundException: %s', $e->getMessage());
  if ($logger) {
- $logger->alert(sprintf('Exception: BadCredentialsException: %s', $e->getMessage()));
+ $logger->alert($msg);
  }
 
- throw $e;
+ throw new NotFoundHttpException($msg);
  } catch (\Exception $e) {
  if ($logger) {
  $logger->alert(sprintf('Exception: \Exception: %s', $e->getMessage()));