Prevent Collection from adding 'rdf:nil rdf:rest rdf:nil.' triples #2818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Creating 'Collection(graph, RDF.nil)' used to add a 'rdf:nil rdf:rest rdf:nil.' triple to the graph, which turned the empty list into an infinite list. This was a side-effect of unconditionally appending 'seq' to the collection, which is not possible when the collection is 'nil' without ill side-effects. This commit makes the append conditional; and also checks the collection is non-empty in case the user explicitly tries to add item to the empty list.
progval force-pushed the collection-empty-list branch from 3fa261d to fc02817 Compare 
progval changed the title 
ashleysommer requested changes Jul 24, 2024
This will allow using _end() in other methods that would not need to append
ashleysommer requested changes Jul 24, 2024
nicholascar changed the title nicholascar added the awaiting feedback 
Co-authored-by: Ashley Sommer <ashleysommer@gmail.com>
ashleysommer requested changes Jul 25, 2024
Co-authored-by: Ashley Sommer <ashleysommer@gmail.com>
nicholascar removed the awaiting feedback 
Contributor
| There's an odd failing test now, weirdly its the same SPARQL test that is failing in #2796 that is completely unrelated to this PR. |
Contributor
| That sporadic test is no longer failing, this can merge. |
ashleysommer approved these changes Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
Creating 'Collection(graph, RDF.nil)' used to add a 'rdf:nil rdf:rest rdf:nil.' triple to the graph, which turned the empty list into an infinite list.
This was a side-effect of unconditionally appending 'seq' to the collection, which is not possible when the collection is 'nil' without ill side-effects.
This commit makes the append conditional; and also checks the collection is non-empty in case the user explicitly tries to add item to the empty list
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.