Skip to content

Conversation

@gal432
Copy link
Member

@gal432 gal432 commented Nov 22, 2021

Still could not reproduce it, but it fixes that

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2021

This pull request introduces 1 alert when merging 32940d5 into 1bc1406 - view on LGTM.com

new alerts:

  • 1 for Unused import
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 22, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.70%.

Quality metrics Before After Change
Complexity 2.40 ⭐ 2.05 ⭐ -0.35 👍
Method Length 50.17 ⭐ 53.00 ⭐ 2.83 👎
Working memory 7.13 🙂 6.88 🙂 -0.25 👍
Quality 78.64% 79.34% 0.70% 👍
Other metrics Before After Change
Lines 180 172 -8
Changed files Quality Before Quality After Quality Change
lms/lmstests/public/unittests/services.py 78.64% ⭐ 79.34% ⭐ 0.70% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lms/lmstests/public/unittests/services.py UnitTestChecker._populate_junit_results 5 ⭐ 100 🙂 11 😞 62.14% 🙂 Extract out complex expressions
lms/lmstests/public/unittests/services.py UnitTestChecker._handle_failed_to_execute_tests 0 ⭐ 62 🙂 11 😞 72.69% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #353 (f609daa) into master (1bc1406) will decrease coverage by 0.06%.
The diff coverage is 92.30%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #353 +/- ## ========================================== - Coverage 84.19% 84.13% -0.07%  ========================================== Files 63 63 Lines 2954 2949 -5 ========================================== - Hits 2487 2481 -6  - Misses 467 468 +1 
Impacted Files Coverage Δ
lms/lmstests/public/unittests/services.py 87.96% <92.30%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc1406...f609daa. Read the comment docs.

@gal432 gal432 merged commit aabe621 into master Nov 22, 2021
@gal432 gal432 deleted the feature/single-testsuite branch November 22, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants