Merge pull request #415 from vesche/tic_tac_toe_refactor

Tic tac toe refactor

Author: chavarera

projects/Tic_tac_toe/README.md

@@ -3,10 +3,9 @@
 ## Description
 
 A python based 2-player Tic Tac Toe game.
-It takes input for the respective x and y coordinates of the two players.
+It takes input of the two players.
 The two players are named as X and O
-and will enter their desired coordinates alternatively to win the game.
-
+and will enter alternating moves in attempt to win the game.
 
 ## Prerequisites
 
@@ -22,5 +21,6 @@ python tic_tac_toe.py
 
 <!-- ## Screenshots/Demo -->
 
-## Author
-[Erfan Saberi](https://github.com/erfansaberi)
+## Authors
+- [Erfan Saberi](https://github.com/erfansaberi)
+- [Austin Jackson](https://github.com/vesche)

projects/Tic_tac_toe/tic_tac_toe.py

@@ -1,103 +1,35 @@
-def start():
- global board
- board = [
- ['','',''],
- ['','',''],
- ['','','']
- ]
-
-def print_board():
- print(' ---------')
- for row in board:
- print(' ',row[0],'|',row[1],'|',row[2])
- print(' ---------')
-
-def have_empty_room():
- for row in board:
- for room in row:
- if not room:
- return True
- return False
-
-def set_room_state(roomxy,state):
- x = int(roomxy[0])-1
- y = int(roomxy[1])-1
- row = board[x]
- room = row[y]
- if not room:
- board[x][y] = state
- return True
- return False
-
-def check_xy(xy):
- xy = str(xy)
- if len(xy) != 2:
- return False
- if int(xy[0]) > 3 or int(xy[0]) < 1 or int(xy[1]) > 3 or int(xy[1]) < 1:
- return False
- return True
-
-def check_for_win():
- if board[0][0] == board[0][1] == board[0][2] != '':
- winner = board[0][0]
- print(f'{winner} won!')
-
- elif board[1][0] == board[1][1] == board[1][2] != '':
- winner = board[1][0]
- print(f'{winner} won!')
-
- elif board[2][0] == board[2][1] == board[2][2] != '':
- winner = board[2][0]
- print(f'{winner} won!')
-
- elif board[0][0] == board[1][0] == board[2][0] != '':
- winner = board[0][0]
- print(f'{winner} won!')
-
- elif board[0][1] == board[1][1] == board[2][1] != '':
- winner = board[0][1]
- print(f'{winner} won!')
-
- elif board[0][2] == board[1][2] == board[2][2] != '':
- winner = board[0][0]
- print(f'{winner} won!')
- 
- elif board[0][0] == board[1][1] == board[2][2] != '':
- winner = board[0][0]
- print(f'{winner} won!')
- 
- elif board[0][2] == board[1][1] == board[2][0] != '':
- winner = board[0][2]
- print(f'{winner} won!')
-
- else:
- return False
- 
- return True
-
-
-turn = 'o'
-start()
-
-while have_empty_room():
- print_board()
- print('\n')
- if turn == 'o':
- turn = 'x'
- else:
- turn = 'o'
- print(f'{turn}\'s Turn!')
- while True:
- xy = int(input('enter x and y: '))
- if check_xy(xy):
- if set_room_state(str(xy),turn):
- break
- print('This room is full!')
- continue
- print('Error!')
- continue
- if check_for_win():
+squares = [' ']*9
+players = 'XO'
+board = '''
+ 0 1 2
+ {0} | {1} | {2}
+ -----------
+3 {3} | {4} | {5} 5
+ -----------
+ {6} | {7} | {8}
+ 6 7 8
+'''
+win_conditions = [
+ (0, 1, 2), (3, 4, 5), (6, 7, 8), # horizontals
+ (0, 3, 6), (1, 4, 7), (2, 5, 8), # verticals
+ (0, 4, 8), (2, 4, 6) # diagonals
+]
+
+def check_win(player):
+ for a, b, c in win_conditions:
+ if {squares[a], squares[b], squares[c]} == {player}:
+ return True
+
+while True:
+ print(board.format(*squares))
+ if check_win(players[1]):
+ print(f'{players[1]} is the winner!')
  break
-print_board()
-print('Game Over')
-input()
+ if ' ' not in squares:
+ print('Cats game!')
+ break
+ move = input(f'{players[0]} to move [0-8] > ')
+ if not move.isdigit() or not 0 <= int(move) <= 8 or squares[int(move)] != ' ':
+ print('Invalid move!')
+ continue
+ squares[int(move)], players = players[0], players[::-1]