Test waitForNavigation returns None on anchor link or navigation due to history

Author: miyakogi

pyppeteer/page.py

@@ -894,8 +894,8 @@ async def waitForNavigation(self, options: dict = None, **kwargs: Any
  which will indirectly cause the page to navigate. In case of navigation
  to a different anchor or navigation due to
  `History API <https://developer.mozilla.org/en-US/docs/Web/API/History_API>`_
- usage, the
- navigation will return ``None``.
+ usage, the navigation will return ``None``.
+
  Consider this example:
 
  .. code::

tests/test_page.py

@@ -614,10 +614,11 @@ async def test_both_domcontentloaded_loaded(self):
  async def test_click_anchor_link(self):
  await self.page.goto(self.url + 'empty')
  await self.page.setContent('<a href="#foobar">foobar</a>')
- await asyncio.wait([
- self.page.click('a'),
+ results = await asyncio.gather(
  self.page.waitForNavigation(),
- ])
+ self.page.click('a'),
+ )
+ self.assertIsNone(results[0])
  self.assertEqual(self.page.url, self.url + 'empty#foobar')
 
  @sync
@@ -637,10 +638,11 @@ async def test_history_push_state(self):
  function pushState() { history.pushState({}, '', 'wow.html') }
  </script>
  ''')
- await asyncio.wait([
- self.page.click('a'),
+ results = await asyncio.gather(
  self.page.waitForNavigation(),
- ])
+ self.page.click('a'),
+ )
+ self.assertIsNone(results[0])
  self.assertEqual(self.page.url, self.url + 'wow.html')
 
  @sync
@@ -654,10 +656,11 @@ async def test_history_replace_state(self):
  }
  </script>
  ''')
- await asyncio.wait([
- self.page.click('a'),
+ results = await asyncio.gather(
  self.page.waitForNavigation(),
- ])
+ self.page.click('a'),
+ )
+ self.assertIsNone(results[0])
  self.assertEqual(self.page.url, self.url + 'replaced.html')
 
  @sync
@@ -674,15 +677,18 @@ async def test_dom_history_back_forward(self):
  </script>
  ''')
  self.assertEqual(self.page.url, self.url + 'second.html')
- await asyncio.wait([
- self.page.click('a#back'),
+ results_back = await asyncio.gather(
  self.page.waitForNavigation(),
- ])
+ self.page.click('a#back'),
+ )
+ self.assertIsNone(results_back[0])
  self.assertEqual(self.page.url, self.url + 'first.html')
- await asyncio.wait([
-  self.page.click('a#forward'),
+
+ results_forward = await asyncio.gather(
  self.page.waitForNavigation(),
- ])
+ self.page.click('a#forward'),
+ )
+ self.assertIsNone(results_forward[0])
  self.assertEqual(self.page.url, self.url + 'second.html')
 
  @sync