Skip to content

Commit 86b9fb4

Browse files
committed
Merge remote-tracking branch 'origin/dev' into dev
2 parents bc3d287 + 3563cfa commit 86b9fb4

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

pyppeteer/browser.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,9 @@ async def close(self) -> None:
264264
async def disconnect(self) -> None:
265265
"""Disconnect browser."""
266266
await self._connection.dispose()
267+
for target in self._targets.values():
268+
if not target._isInitialized:
269+
target._initializedCallback(False)
267270

268271
def _getVersion(self) -> Awaitable:
269272
return self._connection.send('Browser.getVersion')

pyppeteer/tracing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,6 @@ async def _readStream(self, handle: str, path: str) -> str:
9494
result = ''.join(bufs)
9595
if path:
9696
file = Path(path)
97-
with file.open('w') as f:
97+
with file.open('w', encoding='utf-8') as f:
9898
f.write(result)
9999
return result

0 commit comments

Comments
 (0)