don't configure logging

Author: Mattwmaster58

pyppeteer/__init__.py

@@ -6,6 +6,11 @@
 import logging
 import os
 
+from appdirs import AppDirs
+from pyppeteer.launcher import connect, executablePath, launch
+
+from pyppeteer.launcher import defaultArgs # noqa: E402; noqa: E402
+
 try:
  # noinspection PyCompatibility
  from importlib.metadata import version
@@ -19,22 +24,12 @@
 except Exception:
  pass
 
-from appdirs import AppDirs
 
 __chromium_revision__ = '588429'
 __base_puppeteer_version__ = 'v1.6.0'
-__pyppeteer_home__ = os.environ.get(
- 'PYPPETEER_HOME', AppDirs('pyppeteer').user_data_dir) # type: str
+__pyppeteer_home__ = os.environ.get('PYPPETEER_HOME', AppDirs('pyppeteer').user_data_dir) # type: str
 DEBUG = False
 
-# Setup root logger
-_fmt = '[{levelname[0]}:{name}] {msg}'
-logging.basicConfig(level=logging.DEBUG, format=_fmt, style='{')
-_logger = logging.getLogger(__name__)
-_logger.propagate = False
-
-from pyppeteer.launcher import connect, launch, executablePath # noqa: E402
-from pyppeteer.launcher import defaultArgs # noqa: E402
 
 version = __version__
 version_info = tuple(int(i) for i in version.split('.'))

pyppeteer/chromium_downloader.py

@@ -17,6 +17,12 @@
 from tqdm import tqdm
 
 logger = logging.getLogger(__name__)
+# add our own stream handler - we want some output here
+handler = logging.StreamHandler()
+handler.setFormatter(fmt=logging.Formatter(fmt="[{levelname}] {msg}", style="{"))
+handler.setLevel(logging.INFO)
+logger.setLevel(logging.INFO)
+logger.addHandler(handler)
 
 DOWNLOADS_FOLDER = Path(__pyppeteer_home__) / 'local-chromium'
 DEFAULT_DOWNLOAD_HOST = 'https://storage.googleapis.com'
@@ -67,7 +73,7 @@ def get_url() -> str:
 
 def download_zip(url: str) -> BytesIO:
  """Download data from url."""
- logger.info('Starting Chromium download. Download may take a few minutes.')
+ logger.info('Starting Chromium download.')
 
  with urllib3.PoolManager(cert_reqs='CERT_REQUIRED', ca_certs=certifi.where()) as http:
  # Get data from url.
@@ -92,13 +98,13 @@ def download_zip(url: str) -> BytesIO:
  process_bar.update(len(chunk))
  process_bar.close()
 
- logger.info('Chromium download done.')
  return _data
 
 
 def extract_zip(data: BytesIO, path: Path) -> None:
  """Extract zipped data to path."""
  # On mac zipfile module cannot extract correctly, so use unzip instead.
+ logger.info('Beginning extraction')
  if current_platform() == 'mac':
  import subprocess
  import shutil
@@ -125,22 +131,14 @@ def extract_zip(data: BytesIO, path: Path) -> None:
  if not exec_path.exists():
  raise IOError('Failed to extract chromium.')
  exec_path.chmod(exec_path.stat().st_mode | stat.S_IXOTH | stat.S_IXGRP | stat.S_IXUSR)
- logger.info(f'chromium extracted to: {path}')
+ logger.info(f'Chromium extracted to: {path}')
 
 
 def download_chromium() -> None:
  """Download and extract chromium."""
  extract_zip(download_zip(get_url()), DOWNLOADS_FOLDER / REVISION)
 
 
-def chromium_excutable() -> Path:
- """[Deprecated] miss-spelled function.
- Use `chromium_executable` instead.
- """
- logger.warning('`chromium_excutable` function is deprecated. ' 'Use `chromium_executable instead.')
- return chromium_executable()
-
-
 def chromium_executable() -> Path:
  """Get path of the chromium executable."""
  return chromiumExecutable[current_platform()]

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "pyppeteer"
-version = "1.0.0"
+version = "1.0.1"
 description = "Headless chrome/chromium automation library (unofficial port of puppeteer)"
 readme = 'README.md'
 license = "MIT"
@@ -77,7 +77,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.black]
 line-length = 120
-target-version = ['py37', 'py38', 'py39', 'py310']
+target-version = ['py37', 'py38']
 skip-string-normalization = true
 
 [tool.isort]