Skip to content

use FS URLs in multi and mount fs #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 19, 2017
Merged

use FS URLs in multi and mount fs #66

merged 6 commits into from
Aug 19, 2017

Conversation

@willmcgugan
Copy link
Member

@willmcgugan willmcgugan commented Aug 17, 2017 •
edited
Loading

  • Adds openers for app urls, e.g. userdata://myapp:willmcgugan:1.0.
  • Allow MountFS and MultiFS to use FS Urls, e.g. mount_fs.mount('foo', 'mem://')
@coveralls
Copy link

coveralls commented Aug 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling cd139cb on mount-openers into 86b990b on master.
@coveralls
Copy link

coveralls commented Aug 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3f1d386 on mount-openers into 86b990b on master.
1 similar comment
@coveralls
Copy link

coveralls commented Aug 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 3f1d386 on mount-openers into 86b990b on master.
@willmcgugan willmcgugan requested review from althonos and lurch August 17, 2017 21:47
@coveralls
Copy link

coveralls commented Aug 17, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling cd47e24 on mount-openers into 86b990b on master.
althonos
althonos requested changes Aug 18, 2017
View reviewed changes
Copy link
Member

@althonos althonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo in OpenerError, other than that fine by me.
fs/opener/appfs.py Outdated
else:
raise OpenerError(
'resource should be <appname>:<author> '
'or <appname>:<author>:<version'
Copy link
Member

@althonos althonos Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here
Copy link
Member Author

@willmcgugan willmcgugan Aug 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@coveralls
Copy link

coveralls commented Aug 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a876ff4 on mount-openers into 86b990b on master.
@coveralls
Copy link

coveralls commented Aug 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 883328b on mount-openers into 86b990b on master.
1 similar comment
@coveralls
Copy link

coveralls commented Aug 19, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 883328b on mount-openers into 86b990b on master.
@willmcgugan willmcgugan merged commit 0b6f440 into master Aug 19, 2017
@willmcgugan willmcgugan deleted the mount-openers branch August 19, 2017 10:10
@coveralls
Copy link

coveralls commented Aug 19, 2017

Coverage Status

Coverage decreased (-0.6%) to 99.408% when pulling 883328b on mount-openers into 86b990b on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@willmcgugan @coveralls @althonos