Skip to content

Update base.fs.upload docs to reflect exceptions thrown #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2021
Merged

Update base.fs.upload docs to reflect exceptions thrown #445

merged 4 commits into from
Jan 27, 2021

Conversation

@eelkevdbos
Copy link
Contributor

@eelkevdbos eelkevdbos commented Jan 20, 2021 •
edited by althonos
Loading

Type of changes

  • Documentation / docstrings

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

A small docs improvement I came across while using the fs.base.upload method. It reflects the method throwing ResourceNotFound if the path you are uploading to does not exist.
@althonos althonos added the docs Issues related to documentation label Jan 26, 2021
@althonos
Copy link
Member

althonos commented Jan 26, 2021

Thanks for the PR @eelkevdbos !

Could you possibly add a test to reflect this to fs.test? If this is an explicitly advertised behaviour then we need to check all filesystems behave so.
@althonos althonos added this to the v2.4.13 milestone Jan 26, 2021
althonos
althonos requested changes Jan 26, 2021
View reviewed changes
@althonos althonos merged commit ab0ab0c into PyFilesystem:master Jan 27, 2021
@althonos
Copy link
Member

althonos commented Jan 27, 2021

Thanks a bunch!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues related to documentation

2 participants

@eelkevdbos @althonos