Improve apps.go coverage (google#1702)

Author: gmlewis

github/apps_test.go

@@ -37,6 +37,20 @@ func TestAppsService_Get_authenticatedApp(t *testing.T) {
 if !reflect.DeepEqual(app, want) {
 t.Errorf("Apps.Get returned %+v, want %+v", app, want)
 }
+
+const methodName = "Get"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.Get(ctx, "\n")
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.Get(ctx, "")
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_Get_specifiedApp(t *testing.T) {
@@ -159,6 +173,15 @@ func TestAppsService_ListInstallations(t *testing.T) {
 if !reflect.DeepEqual(installations, want) {
 t.Errorf("Apps.ListInstallations returned %+v, want %+v", installations, want)
 }
+
+const methodName = "ListInstallations"
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.ListInstallations(ctx, opt)
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_GetInstallation(t *testing.T) {
@@ -180,6 +203,20 @@ func TestAppsService_GetInstallation(t *testing.T) {
 if !reflect.DeepEqual(installation, want) {
 t.Errorf("Apps.GetInstallation returned %+v, want %+v", installation, want)
 }
+
+const methodName = "GetInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.GetInstallation(ctx, -1)
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.GetInstallation(ctx, 1)
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_ListUserInstallations(t *testing.T) {
@@ -206,6 +243,15 @@ func TestAppsService_ListUserInstallations(t *testing.T) {
 if !reflect.DeepEqual(installations, want) {
 t.Errorf("Apps.ListUserInstallations returned %+v, want %+v", installations, want)
 }
+
+const methodName = "ListUserInstallations"
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.ListUserInstallations(ctx, opt)
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_SuspendInstallation(t *testing.T) {
@@ -222,6 +268,16 @@ func TestAppsService_SuspendInstallation(t *testing.T) {
 if _, err := client.Apps.SuspendInstallation(ctx, 1); err != nil {
 t.Errorf("Apps.SuspendInstallation returned error: %v", err)
 }
+
+const methodName = "SuspendInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, err = client.Apps.SuspendInstallation(ctx, -1)
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+return client.Apps.SuspendInstallation(ctx, 1)
+})
 }
 
 func TestAppsService_UnsuspendInstallation(t *testing.T) {
@@ -238,6 +294,16 @@ func TestAppsService_UnsuspendInstallation(t *testing.T) {
 if _, err := client.Apps.UnsuspendInstallation(ctx, 1); err != nil {
 t.Errorf("Apps.UnsuspendInstallation returned error: %v", err)
 }
+
+const methodName = "UnsuspendInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, err = client.Apps.UnsuspendInstallation(ctx, -1)
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+return client.Apps.UnsuspendInstallation(ctx, 1)
+})
 }
 
 func TestAppsService_DeleteInstallation(t *testing.T) {
@@ -254,6 +320,16 @@ func TestAppsService_DeleteInstallation(t *testing.T) {
 if err != nil {
 t.Errorf("Apps.DeleteInstallation returned error: %v", err)
 }
+
+const methodName = "DeleteInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, err = client.Apps.DeleteInstallation(ctx, -1)
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+return client.Apps.DeleteInstallation(ctx, 1)
+})
 }
 
 func TestAppsService_CreateInstallationToken(t *testing.T) {
@@ -275,6 +351,20 @@ func TestAppsService_CreateInstallationToken(t *testing.T) {
 if !reflect.DeepEqual(token, want) {
 t.Errorf("Apps.CreateInstallationToken returned %+v, want %+v", token, want)
 }
+
+const methodName = "CreateInstallationToken"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.CreateInstallationToken(ctx, -1, nil)
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.CreateInstallationToken(ctx, 1, nil)
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_CreateInstallationTokenWithOptions(t *testing.T) {
@@ -346,6 +436,20 @@ func TestAppsService_CreateAttachement(t *testing.T) {
 if !reflect.DeepEqual(got, want) {
 t.Errorf("CreateAttachment = %+v, want %+v", got, want)
 }
+
+const methodName = "CreateAttachment"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.CreateAttachment(ctx, -11, "\n", "\n")
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.CreateAttachment(ctx, 11, "title1", "body1")
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_FindOrganizationInstallation(t *testing.T) {
@@ -367,6 +471,20 @@ func TestAppsService_FindOrganizationInstallation(t *testing.T) {
 if !reflect.DeepEqual(installation, want) {
 t.Errorf("Apps.FindOrganizationInstallation returned %+v, want %+v", installation, want)
 }
+
+const methodName = "FindOrganizationInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.FindOrganizationInstallation(ctx, "\n")
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.FindOrganizationInstallation(ctx, "o")
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_FindRepositoryInstallation(t *testing.T) {
@@ -388,6 +506,20 @@ func TestAppsService_FindRepositoryInstallation(t *testing.T) {
 if !reflect.DeepEqual(installation, want) {
 t.Errorf("Apps.FindRepositoryInstallation returned %+v, want %+v", installation, want)
 }
+
+const methodName = "FindRepositoryInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.FindRepositoryInstallation(ctx, "\n", "\n")
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.FindRepositoryInstallation(ctx, "o", "r")
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_FindRepositoryInstallationByID(t *testing.T) {
@@ -409,6 +541,20 @@ func TestAppsService_FindRepositoryInstallationByID(t *testing.T) {
 if !reflect.DeepEqual(installation, want) {
 t.Errorf("Apps.FindRepositoryInstallationByID returned %+v, want %+v", installation, want)
 }
+
+const methodName = "FindRepositoryInstallationByID"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.FindRepositoryInstallationByID(ctx, -1)
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.FindRepositoryInstallationByID(ctx, 1)
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 func TestAppsService_FindUserInstallation(t *testing.T) {
@@ -430,6 +576,20 @@ func TestAppsService_FindUserInstallation(t *testing.T) {
 if !reflect.DeepEqual(installation, want) {
 t.Errorf("Apps.FindUserInstallation returned %+v, want %+v", installation, want)
 }
+
+const methodName = "FindUserInstallation"
+testBadOptions(t, methodName, func() (err error) {
+_, _, err = client.Apps.FindUserInstallation(ctx, "\n")
+return err
+})
+
+testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
+got, resp, err := client.Apps.FindUserInstallation(ctx, "u")
+if got != nil {
+t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
+}
+return resp, err
+})
 }
 
 // GetReadWriter converts a body interface into an io.ReadWriter object.