Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Mar 17, 2023

part of Project-MONAI/MONAI#6156

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pre-commit-ci bot and others added 3 commits March 17, 2023 13:05
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli and others added 3 commits March 18, 2023 10:33
…ctional Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@review-notebook-app
Copy link

review-notebook-app bot commented Mar 19, 2023

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2023-03-19T10:15:23Z
----------------------------------------------------------------

Line #7. 

I think we could also add print(f"img original shape: {img.shape}") here then when we do the lazy evaluation, users won't be confused about the shape.


@review-notebook-app
Copy link

review-notebook-app bot commented Mar 19, 2023

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2023-03-19T10:15:24Z
----------------------------------------------------------------

Line #12. rand_windows.set_random_state(0) 

May I ask why we both need set set_determinism(1234) and set_random_state(0) here?


@review-notebook-app
Copy link

review-notebook-app bot commented Mar 19, 2023

View / edit / reply to this conversation on ReviewNB

KumoLiu commented on 2023-03-19T10:15:25Z
----------------------------------------------------------------

Line #2. 

We could also print("non-lazy evaluation time:") here and print("lazy evaluation time:") in the below cell?


Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just leave some comments in line, feel free to ignore them, thanks!

wyli added 2 commits March 19, 2023 10:43
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit 5608c43 into Project-MONAI:main Mar 19, 2023
@wyli wyli deleted the lazy-resampling-functional branch March 19, 2023 11:54
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
part of Project-MONAI/MONAI#6156 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants