Skip to content

Address SonarQube issues #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 14, 2022
Merged

Address SonarQube issues #66

merged 5 commits into from
Mar 14, 2022

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Mar 14, 2022 •
edited
Loading

Fixes #65 .

Description

Address issues reported by SonarQube.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp
gh-65 address SonarQube issues
203b8a8 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the bug Something isn't working label Mar 14, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Mar 14, 2022
@mocsharp mocsharp self-assigned this Mar 14, 2022
@mocsharp
gh-65 combine unit test job with sonarqube
7ee6d03 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
gh-65 address additional warnings reported by sonarqube
e9bab86 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@Project-MONAI Project-MONAI deleted a comment from codecov bot Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022 •
edited
Loading

Codecov Report

Merging #66 (8b7fc7f) into develop (0c9b358) will decrease coverage by 92.57542%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #66 +/- ## =================================================== - Coverage 92.57542% 0.00000% -92.57542%  =================================================== Files 203 203 Lines 12297 12344 +47 Branches 622 624 +2 =================================================== - Hits 11384 0 -11384  - Misses 730 12343 +11613  + Partials 183 1 -182
Flag Coverage Δ
unittests 0.00000% <0.00000%> (-92.57542%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/LoggingDataDictionary.cs 0.00000% <0.00000%> (-100.00000%) ⬇️
src/Api/MessageBroker/JsonMessage.cs 0.00000% <0.00000%> (-77.77779%) ⬇️
src/Api/MessageBroker/MessageContentTypes.cs 0.00000% <0.00000%> (ø)
src/Api/Rest/InferenceRequest.cs 0.00000% <0.00000%> (-100.00000%) ⬇️
src/Api/Rest/InferenceRequestException.cs 0.00000% <0.00000%> (-100.00000%) ⬇️
src/Api/Storage/FileStorageInfo.cs 0.00000% <ø> (-100.00000%) ⬇️
src/Api/Storage/Payload.cs 0.00000% <ø> (-100.00000%) ⬇️
src/CLI/Commands/ConfigCommand.cs 0.00000% <0.00000%> (-100.00000%) ⬇️
src/CLI/Commands/ConfigurationException.cs 0.00000% <0.00000%> (-100.00000%) ⬇️
src/CLI/Commands/RestartCommand.cs 0.00000% <0.00000%> (-100.00000%) ⬇️
... and 227 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9b358...8b7fc7f. Read the comment docs.
@mocsharp
gh-65 add sonarqube unit test report path
9e1cc0f 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
gh-65 fix warnings reported by sonarqube
8b7fc7f 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication
@mocsharp mocsharp merged commit 0fca397 into develop Mar 14, 2022
@github-actions
Copy link

github-actions bot commented Aug 19, 2022

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

2 participants

@mocsharp