Skip to content

Extract and store DICOM JSON. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Extract and store DICOM JSON. #43

merged 1 commit into from
Feb 4, 2022

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Feb 4, 2022 •
edited
Loading

Fixes #36

Description

  • convert and store DICOM to JSON format.
    • An enhancement has been filed with fo-dicom to support the option of not writing other value types. Until then, a copy of the code is included.
  • update WorkflowRequestMessage structure

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp
Implment #36 extract and store DICOM JSON.
ef94ff0 
- update WorkflowRequestMessage structure
@mocsharp mocsharp added the enhancement Enhancement to existing feature label Feb 4, 2022
@mocsharp mocsharp self-assigned this Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #43 (ef94ff0) into main (b0e1ef8) will decrease coverage by 5.58398%.
The diff coverage is 22.37001%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #43 +/- ## =================================================== - Coverage 87.27756% 81.69358% -5.58398%  =================================================== Files 157 158 +1 Lines 8654 9412 +758 Branches 535 656 +121 =================================================== + Hits 7553 7689 +136  - Misses 927 1540 +613  - Partials 174 183 +9
Flag Coverage Δ
unittests 81.69358% <22.37001%> (-5.58398%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/MessageBroker/Message.cs 80.95238% <ø> (+24.28571%) ⬆️
...grations/InformaticsGatewayContextModelSnapshot.cs 0.00000% <0.00000%> (ø)
...icsGateway/Services/Connectors/PayloadAssembler.cs 85.71429% <ø> (+3.30688%) ⬆️
.../InformaticsGateway/Common/DicomToJsonConverter.cs 9.25110% <9.25110%> (ø)
src/Api/Storage/DicomFileStorageInfo.cs 58.33333% <58.62069%> (-1.66668%) ⬇️
src/Api/Storage/FhirFileStorageInfo.cs 61.90476% <60.00000%> (+6.34920%) ⬆️
...csGateway/Services/Scp/ApplicationEntityManager.cs 70.49180% <78.57143%> (ø)
src/Api/Storage/FileStorageInfo.cs 90.76923% <91.66667%> (+1.67831%) ⬆️
src/Api/Storage/Payload.cs 100.00000% <100.00000%> (ø)
...igrations/20220203222116_R1_Initialize.Designer.cs 100.00000% <100.00000%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e1ef8...ef94ff0. Read the comment docs.
@GreySeaWolf GreySeaWolf merged commit ed72aca into main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to existing feature

3 participants

@mocsharp @GreySeaWolf