Skip to content

Upgrade to .NET 6 & fo-dicom 5 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2021
Merged

Upgrade to .NET 6 & fo-dicom 5 #21

merged 4 commits into from
Dec 15, 2021

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 12, 2021 •
edited
Loading

Description

Upgrades to .NET 6 LTS

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp mocsharp marked this pull request as draft November 12, 2021 00:00
@codecov
Copy link

codecov bot commented Nov 12, 2021 •
edited
Loading

Codecov Report

Merging #21 (9f7a44e) into main (380d8ee) will increase coverage by 5.12306%.
The diff coverage is 58.46154%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #21 +/- ## =================================================== + Coverage 80.50351% 85.62657% +5.12305%  =================================================== Files 149 145 -4 Lines 8699 7980 -719 Branches 581 488 -93 =================================================== - Hits 7003 6833 -170  + Misses 1507 974 -533  + Partials 189 173 -16
Flag Coverage Δ
unittests 85.62657% <58.46154%> (+5.12305%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/CLI/Program.cs 0.00000% <0.00000%> (ø)
src/Client.Common/UriExtensions.cs 87.50000% <0.00000%> (ø)
src/Configuration/ScpConfiguration.cs 100.00000% <ø> (+46.15384%) ⬆️
src/DicomWebClient/API/DicomWebClientException.cs 100.00000% <ø> (+40.00000%) ⬆️
src/DicomWebClient/API/MimeMappings.cs 100.00000% <ø> (ø)
...omWebClient/Common/HttpResponseMessageExtension.cs 100.00000% <ø> (ø)
src/DicomWebClient/Services/WadoService.cs 80.00000% <ø> (ø)
...rc/DicomWebClient/Test/HttpMessageExtensionTest.cs 94.73684% <ø> (ø)
src/DicomWebClient/Test/QidoServiceTest.cs 100.00000% <ø> (ø)
src/DicomWebClient/Test/StowServiceTest.cs 100.00000% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062d573...9f7a44e. Read the comment docs.
@mocsharp mocsharp changed the title Upgrade to .NET 6 Upgrade to .NET 6 & fo-dicom 5 Nov 15, 2021
@mocsharp mocsharp force-pushed the vchang/dotnet6 branch 3 times, most recently from e353a9b to a8f526c Compare November 15, 2021 22:33
@mocsharp mocsharp self-assigned this Nov 15, 2021
@mocsharp mocsharp marked this pull request as ready for review November 15, 2021 22:50
@mocsharp mocsharp added the enhancement Enhancement to existing feature label Nov 18, 2021
@mocsharp mocsharp merged commit 4166763 into main Dec 15, 2021
@mocsharp mocsharp deleted the vchang/dotnet6 branch December 15, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to existing feature

2 participants

@mocsharp