Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 9, 2021

Description

Update design specification to reflect recent DRD #19 changes.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp mocsharp added the documentation Improvements or additions to documentation label Nov 18, 2021
@hshuaib90
Copy link
Collaborator

Thanks for this great work Victor. I think one of the key services missing is alerting/notification. This can be done via email (see page 6 "Sending automated email" https://s3-eu-west-1.amazonaws.com/comms-mat/Training-Materials/Guidance/applicationsguide.pdf) and/or perhaps some configurable generic POST API.

Copy link

@joshliberty joshliberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good - the one comment I have is about the export & result download.

@mocsharp
Copy link
Collaborator Author

Thanks for this great work Victor. I think one of the key services missing is alerting/notification. This can be done via email (see page 6 "Sending automated email" https://s3-eu-west-1.amazonaws.com/comms-mat/Training-Materials/Guidance/applicationsguide.pdf) and/or perhaps some configurable generic POST API.

Do we want a standalone service that aggregates events from all subsystems or shall each subsystem manage its own?
@dbericat

@dbericat
Copy link
Member

Thanks for this great work Victor. I think one of the key services missing is alerting/notification. This can be done via email (see page 6 "Sending automated email" https://s3-eu-west-1.amazonaws.com/comms-mat/Training-Materials/Guidance/applicationsguide.pdf✎ EditSign) and/or perhaps some configurable generic POST API.

Do we want a standalone service that aggregates events from all subsystems or shall each subsystem manage its own? @dbericat

IMO 1 standalone service works best. Avoids duplication of effort and keeps the sub-systems leaner.

But by design, we are not expecting every adopter to use the whole system. So, each sub-system should be able to package/use that micro-service/component/library locally (or externally).

What do others think?

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #20 (70448b8) into main (062d573) will decrease coverage by 0.02299%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## main #20 +/- ## =================================================== - Coverage 80.51500% 80.49201% -0.02300%  =================================================== Files 149 149 Lines 8699 8699 Branches 581 581 =================================================== - Hits 7004 7002 -2  - Misses 1504 1505 +1  - Partials 191 192 +1 
Flag Coverage Δ
unittests 80.49201% <ø> (-0.02300%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Connectors/WorkloadManagerNotificationService.cs 75.00000% <0.00000%> (-2.50000%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe147c...70448b8. Read the comment docs.

@mocsharp mocsharp merged commit 581b028 into main Dec 15, 2021
@mocsharp mocsharp deleted the vchang/srs-update branch December 15, 2021 22:02
@mocsharp mocsharp restored the vchang/srs-update branch December 16, 2021 02:13
@mocsharp mocsharp deleted the vchang/srs-update branch December 16, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

7 participants