- Notifications
You must be signed in to change notification settings - Fork 12
Update SRS to reflect DRD changes #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for this great work Victor. I think one of the key services missing is alerting/notification. This can be done via email (see page 6 "Sending automated email" https://s3-eu-west-1.amazonaws.com/comms-mat/Training-Materials/Guidance/applicationsguide.pdf) and/or perhaps some configurable generic POST API. |
joshliberty left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good - the one comment I have is about the export & result download.
Do we want a standalone service that aggregates events from all subsystems or shall each subsystem manage its own? |
IMO 1 standalone service works best. Avoids duplication of effort and keeps the sub-systems leaner. But by design, we are not expecting every adopter to use the whole system. So, each sub-system should be able to package/use that micro-service/component/library locally (or externally). What do others think? |
607b596 to 8d499b7 Compare Codecov Report
@@ Coverage Diff @@ ## main #20 +/- ## =================================================== - Coverage 80.51500% 80.49201% -0.02300% =================================================== Files 149 149 Lines 8699 8699 Branches 581 581 =================================================== - Hits 7004 7002 -2 - Misses 1504 1505 +1 - Partials 191 192 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Description
Update design specification to reflect recent DRD #19 changes.
Status
Ready
Types of changes
./src/run-tests-in-docker.sh.