Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 8, 2021

Description

Updates DRD to reflect changes in the Workflow Manager:

  • Support waiting and grouping of data
  • Notify subsystems upon data arrival

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp mocsharp self-assigned this Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #19 (ebf9fb6) into main (062d573) will decrease coverage by 0.03448%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## main #19 +/- ## =================================================== - Coverage 80.51500% 80.48052% -0.03449%  =================================================== Files 149 149 Lines 8699 8699 Branches 581 581 =================================================== - Hits 7004 7001 -3  - Misses 1504 1508 +4  + Partials 191 190 -1 
Flag Coverage Δ
unittests 80.48052% <ø> (-0.03449%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InformaticsGateway/Services/Scp/ScpService.cs 74.13793% <0.00000%> (-5.17241%) ⬇️
...s/Connectors/WorkloadManagerNotificationService.cs 75.00000% <0.00000%> (-2.50000%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 83.28691% <0.00000%> (+0.55710%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062d573...ebf9fb6. Read the comment docs.

@mocsharp mocsharp mentioned this pull request Nov 9, 2021
7 tasks
@mocsharp mocsharp added the documentation Improvements or additions to documentation label Nov 18, 2021
@mocsharp mocsharp force-pushed the vchang/drd-update branch 2 times, most recently from 7e06f3f to c4ced4f Compare December 1, 2021 23:18
@mocsharp mocsharp merged commit fbe147c into main Dec 15, 2021
@mocsharp mocsharp deleted the vchang/drd-update branch December 15, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

3 participants