Skip to content

Conversation

@neildsouth
Copy link
Member

@neildsouth neildsouth commented Sep 26, 2022

Description

Added logging packages (serilog) and the work needed to log across the workflow

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #170 (22c11e2) into develop (dc898fe) will increase coverage by 0.00002%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #170 +/- ## =================================================== + Coverage 92.84242% 92.84244% +0.00001%  =================================================== Files 261 261 Lines 14558 14572 +14 Branches 770 770 =================================================== + Hits 13516 13529 +13  - Misses 813 814 +1  Partials 229 229 
Flag Coverage Δ
unittests 92.84244% <100.00000%> (+0.00001%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/InformaticsGateway/Program.cs 93.54839% <100.00000%> (+0.82111%) ⬆️
...Gateway/Repositories/InferenceRequestRepository.cs 94.04762% <0.00000%> (-1.19049%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc898fe...22c11e2. Read the comment docs.

@mocsharp
Copy link
Collaborator

Please update docs (default config & logging sections) to reflect logging changes https://github.com/Project-MONAI/monai-deploy-informatics-gateway/blob/develop/docs/setup/schema.md#default-configuration

Signed-off-by: Neil South <neil.south@answerdigital.com>
@mocsharp mocsharp merged commit 148c1e4 into develop Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants