Skip to content

Conversation

@mocsharp
Copy link
Collaborator

Description

  • Update CLI to support Docker as a runner option.
  • Define APIs for supporting other orchestration engines, .e.g Helm.

Commands:

wig init #to initialize Informatics Gateway with the default configuration file in ~/.mig wig start #to start the Informatics Gateway using the configured runner wig stop #to stop the Informatics Gateway using the configured runner wig restart #to restart the Informatics Gateway using the configured runner wig config wmgrpc <URI> #configure the endpoint for the GRPC service of MWM wig config wmrest <URI> #configure the endpoint for the REST service of MWM wig config runner <runner> #configure the runner for Informatics Gateway wig config endpoint <URI> #configure the endpoint of Informatics Gateway server

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp mocsharp added the enhancement Enhancement to existing feature label Sep 27, 2021
@mocsharp mocsharp self-assigned this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #17 (ff5f999) into vchang/docs (1aeb731) will increase coverage by 0.57085%.
The diff coverage is 86.06061%.

❗ Current head ff5f999 differs from pull request most recent head 7081f49. Consider uploading reports for the commit 7081f49 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## vchang/docs #17 +/- ## ===================================================== + Coverage 79.80352% 80.37437% +0.57084%  ===================================================== Files 142 149 +7 Lines 7838 8708 +870 Branches 555 581 +26 ===================================================== + Hits 6255 6999 +744  - Misses 1389 1517 +128  + Partials 194 192 -2 
Flag Coverage Δ
unittests 80.37437% <86.06061%> (+0.57084%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/CLI/Commands/ConfigurationException.cs 100.00000% <ø> (ø)
src/CLI/Logging/ConsoleLoggerFactoryExtensions.cs 12.50000% <0.00000%> (+2.50000%) ⬆️
src/CLI/Program.cs 0.00000% <0.00000%> (ø)
src/CLI/Services/ConfirmationPrompt.cs 0.00000% <0.00000%> (ø)
src/CLI/Services/EmbeddedResource.cs 0.00000% <0.00000%> (ø)
src/Client.Common/ProblemException.cs 87.50000% <ø> (ø)
...Configuration/MonaiWorkloadManagerConfiguration.cs 37.50000% <ø> (ø)
src/Configuration/Test/ValidationExtensionsTest.cs 100.00000% <ø> (ø)
...igrations/20210923225957_R1_Initialize.Designer.cs 0.00000% <0.00000%> (ø)
...atabase/Migrations/20210923225957_R1_Initialize.cs 0.00000% <0.00000%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeb731...7081f49. Read the comment docs.

@mocsharp mocsharp changed the base branch from main to vchang/docs October 4, 2021 22:31
@mocsharp mocsharp merged commit 380d8ee into vchang/docs Nov 15, 2021
@mocsharp mocsharp deleted the vchang/cli_docker branch February 3, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to existing feature

3 participants