Skip to content

Conversation

@mocsharp
Copy link
Collaborator

Description

Upgrades fo-dicom to 4.0.8

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp mocsharp self-assigned this Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #14 (a09d086) into main (cfd79ea) will increase coverage by 0.29202%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #14 +/- ## =================================================== + Coverage 76.41224% 76.70426% +0.29202%  =================================================== Files 97 97 Lines 5948 5941 -7 Branches 507 498 -9 =================================================== + Hits 4545 4557 +12  + Misses 1221 1212 -9  + Partials 182 172 -10 
Flag Coverage Δ
unittests 76.70426% <100.00000%> (+0.29202%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/DicomWebClient/API/MimeMappings.cs 100.00000% <100.00000%> (ø)
...maticsGateway/Services/Export/ExportServiceBase.cs 88.35616% <100.00000%> (+1.03222%) ⬆️
...s/Connectors/WorkloadManagerNotificationService.cs 83.33333% <0.00000%> (-2.77778%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 85.10029% <0.00000%> (-0.57306%) ⬇️
src/DicomWebClient/Services/ServiceBase.cs 94.23077% <0.00000%> (-0.21367%) ⬇️
src/DicomWebClient/DicomWebClient.cs 100.00000% <0.00000%> (ø)
src/DicomWebClient/API/DicomWebResponse.cs 100.00000% <0.00000%> (ø)
src/DicomWebClient/Test/StowServiceTest.cs 100.00000% <0.00000%> (ø)
src/DicomWebClient/API/DicomWebClientException.cs 50.00000% <0.00000%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697899c...a09d086. Read the comment docs.

@mocsharp mocsharp merged commit 5d02985 into main Sep 13, 2021
@mocsharp mocsharp deleted the vchang/fo-dicom-408 branch September 13, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants