Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 9, 2021

Description

Adjust retries on unit test to prevent unit test from failing on GHA.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog
@mocsharp mocsharp self-assigned this Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #13 (63faa71) into main (cfd79ea) will decrease coverage by 0.00095%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@ Coverage Diff @@ ## main #13 +/- ## =================================================== - Coverage 76.41224% 76.41129% -0.00096%  =================================================== Files 97 97 Lines 5948 5952 +4 Branches 507 507 =================================================== + Hits 4545 4548 +3  - Misses 1221 1222 +1  Partials 182 182 
Flag Coverage Δ
unittests 76.41129% <100.00000%> (-0.00096%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...maticsGateway/Services/Export/ExportServiceBase.cs 88.35616% <100.00000%> (+1.03222%) ⬆️
...s/Connectors/WorkloadManagerNotificationService.cs 83.33333% <0.00000%> (-2.77778%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697899c...63faa71. Read the comment docs.

@mocsharp mocsharp force-pushed the vchang/optimize-unit-test branch from 8027c9a to e83a655 Compare September 10, 2021 00:09
@mocsharp mocsharp force-pushed the vchang/optimize-unit-test branch from e83a655 to 63faa71 Compare September 10, 2021 17:03
@mocsharp mocsharp requested a review from whoisj September 10, 2021 22:07
@mocsharp mocsharp merged commit 63faa71 into main Sep 13, 2021
Copy link

@pritishnahar95 pritishnahar95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mocsharp mocsharp deleted the vchang/optimize-unit-test branch September 13, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants