Change WriteErrorsToHost to ThrowOnError

Author: rjmholt

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/ConfigurationDoneHandler.cs

@@ -28,6 +28,7 @@ internal class ConfigurationDoneHandler : IConfigurationDoneHandler
  MustRunInForeground = true,
  WriteInputToHost = true,
  WriteOutputToHost = true,
+ ThrowOnError = false,
  AddToHistory = true,
  };
 

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/DebugEvaluateHandler.cs

@@ -50,7 +50,7 @@ public async Task<EvaluateResponseBody> Handle(EvaluateRequestArguments request,
  _executionService.ExecutePSCommandAsync(
  new PSCommand().AddScript(request.Expression),
  CancellationToken.None,
- new PowerShellExecutionOptions { WriteOutputToHost = true }).HandleErrorsAsync(_logger);
+ new PowerShellExecutionOptions { WriteOutputToHost = true, ThrowOnError = false, AddToHistory = true }).HandleErrorsAsync(_logger);
  }
  else
  {

src/PowerShellEditorServices/Services/Extension/ExtensionService.cs

@@ -135,7 +135,7 @@ public async Task InvokeCommandAsync(string commandName, EditorContext editorCon
  await ExecutionService.ExecutePSCommandAsync(
  executeCommand,
  CancellationToken.None,
- new PowerShellExecutionOptions { WriteOutputToHost = !editorCommand.SuppressOutput })
+ new PowerShellExecutionOptions { WriteOutputToHost = !editorCommand.SuppressOutput, ThrowOnError = false, AddToHistory = !editorCommand.SuppressOutput })
  .ConfigureAwait(false);
  }
  else

src/PowerShellEditorServices/Services/PowerShell/Execution/ExecutionOptions.cs

@@ -39,15 +39,15 @@ public record PowerShellExecutionOptions : ExecutionOptions
  InterruptCurrentForeground = false,
  WriteOutputToHost = false,
  WriteInputToHost = false,
- WriteErrorsToHost = false,
+ ThrowOnError = true,
  AddToHistory = false,
  };
 
  public bool WriteOutputToHost { get; init; }
 
  public bool WriteInputToHost { get; init; }
 
- public bool WriteErrorsToHost { get; init; }
+ public bool ThrowOnError { get; init; }
 
  public bool AddToHistory { get; init; }
  }

src/PowerShellEditorServices/Services/PowerShell/Execution/SynchronousPowerShellTask.cs

@@ -75,7 +75,7 @@ private IReadOnlyList<TResult> ExecuteNormally(CancellationToken cancellationTok
  AddToHistory = PowerShellExecutionOptions.AddToHistory,
  };
 
- if (!PowerShellExecutionOptions.WriteErrorsToHost)
+ if (PowerShellExecutionOptions.ThrowOnError)
  {
  invocationSettings.ErrorActionPreference = ActionPreference.Stop;
  }
@@ -94,7 +94,7 @@ private IReadOnlyList<TResult> ExecuteNormally(CancellationToken cancellationTok
  {
  Logger.LogWarning($"Runtime exception occurred while executing command:{Environment.NewLine}{Environment.NewLine}{e}");
 
- if (!PowerShellExecutionOptions.WriteErrorsToHost)
+ if (PowerShellExecutionOptions.ThrowOnError)
  {
  throw;
  }
@@ -161,7 +161,7 @@ private IReadOnlyList<TResult> ExecuteInDebugger(CancellationToken cancellationT
  {
  Logger.LogWarning($"Runtime exception occurred while executing command:{Environment.NewLine}{Environment.NewLine}{e}");
 
- if (!PowerShellExecutionOptions.WriteErrorsToHost)
+ if (!PowerShellExecutionOptions.ThrowOnError)
  {
  throw;
  }

src/PowerShellEditorServices/Services/PowerShell/Handlers/EvaluateHandler.cs

@@ -35,7 +35,7 @@ public Task<EvaluateResponseBody> Handle(EvaluateRequestArguments request, Cance
  _executionService.ExecutePSCommandAsync(
  new PSCommand().AddScript(request.Expression),
  CancellationToken.None,
- new PowerShellExecutionOptions { WriteInputToHost = true, WriteOutputToHost = true, AddToHistory = true });
+ new PowerShellExecutionOptions { WriteInputToHost = true, WriteOutputToHost = true, AddToHistory = true, ThrowOnError = false });
 
  return Task.FromResult(new EvaluateResponseBody
  {

src/PowerShellEditorServices/Services/PowerShell/Handlers/GetVersionHandler.cs

@@ -127,7 +127,7 @@ private async Task CheckPackageManagement()
  await _executionService.ExecutePSCommandAsync(
  command,
  CancellationToken.None,
- new PowerShellExecutionOptions { WriteInputToHost = true, WriteOutputToHost = true, AddToHistory = true }).ConfigureAwait(false);
+ new PowerShellExecutionOptions { WriteInputToHost = true, WriteOutputToHost = true, AddToHistory = true, ThrowOnError = false }).ConfigureAwait(false);
 
  // TODO: Error handling here
 

src/PowerShellEditorServices/Services/PowerShell/Handlers/ShowHelpHandler.cs

@@ -74,7 +74,7 @@ public async Task<Unit> Handle(ShowHelpParams request, CancellationToken cancell
 
  // TODO: Rather than print the help in the console, we should send the string back
  // to VSCode to display in a help pop-up (or similar)
- await _executionService.ExecutePSCommandAsync<PSObject>(checkHelpPSCommand, cancellationToken, new PowerShellExecutionOptions { WriteOutputToHost = true }).ConfigureAwait(false);
+ await _executionService.ExecutePSCommandAsync<PSObject>(checkHelpPSCommand, cancellationToken, new PowerShellExecutionOptions { WriteOutputToHost = true, ThrowOnError = false }).ConfigureAwait(false);
  return Unit.Value;
  }
  }

src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs

@@ -179,7 +179,7 @@ public async Task StartAsync(HostStartOptions startOptions, CancellationToken ca
  {
  await ExecuteDelegateAsync(
  "LoadProfiles",
- new PowerShellExecutionOptions { MustRunInForeground = true },
+ new PowerShellExecutionOptions { MustRunInForeground = true, ThrowOnError = false },
  (pwsh, delegateCancellation) => pwsh.LoadProfiles(_hostInfo.ProfilePaths),
  cancellationToken).ConfigureAwait(false);
 
@@ -549,7 +549,7 @@ private string InvokeReadLine(CancellationToken cancellationToken)
  private void InvokeInput(string input, CancellationToken cancellationToken)
  {
  var command = new PSCommand().AddScript(input, useLocalScope: false);
- InvokePSCommand(command, new PowerShellExecutionOptions { AddToHistory = true, WriteErrorsToHost = true, WriteOutputToHost = true }, cancellationToken);
+ InvokePSCommand(command, new PowerShellExecutionOptions { AddToHistory = true, ThrowOnError = false, WriteOutputToHost = true }, cancellationToken);
  }
 
  private void AddRunspaceEventHandlers(Runspace runspace)

src/PowerShellEditorServices/Services/Template/TemplateService.cs

@@ -166,7 +166,7 @@ public async Task<bool> CreateFromTemplateAsync(
  await _executionService.ExecutePSCommandAsync(
  command,
  CancellationToken.None,
- new PowerShellExecutionOptions { WriteOutputToHost = true, InterruptCurrentForeground = true }).ConfigureAwait(false);
+ new PowerShellExecutionOptions { WriteOutputToHost = true, InterruptCurrentForeground = true, ThrowOnError = false }).ConfigureAwait(false);
 
  // If any errors were written out, creation was not successful
  return true;