Skip to content

Commit 193de31

Browse files
authored
fix: Fix string/comma problem in worker template (#782)
1 parent 1a65077 commit 193de31

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed

charts/posthog/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type: application
1111

1212
# This is the chart version. This version number should be incremented each time you make changes
1313
# to the chart and its templates, including the app version.
14-
version: 30.37.0
14+
version: 30.38.0
1515

1616
# This is the version number of the application being deployed. This version number should be
1717
# incremented each time you make changes to the application.

charts/posthog/templates/worker-deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ spec:
127127
{{- include "snippet.email-env" $ | nindent 8 }}
128128
{{- if .queues }}
129129
- name: CELERY_WORKER_QUEUES
130-
value: "{{ .queues | join ',' }}"
130+
value: "{{ .queues | join "," }}"
131131
{{- end }}
132132
{{- if .concurrency }}
133133
- name: CELERY_WORKER_CONCURRENCY

charts/posthog/tests/worker-deployment.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,3 +125,30 @@ tests:
125125
- equal:
126126
path: spec.template.spec.imagePullSecrets
127127
value: [name: secret]
128+
- it: set consumer config correctly
129+
template: templates/worker-deployment.yaml # TODO: remove once secrets.yaml will be fixed/removed
130+
set:
131+
cloud: local
132+
worker.consumers:
133+
- name: gevent
134+
pool: gevent
135+
concurrency: 50
136+
queues:
137+
- analytics_queries
138+
- other
139+
asserts:
140+
- contains:
141+
path: spec.template.spec.containers[0].env
142+
content:
143+
name: CELERY_WORKER_QUEUES
144+
value: analytics_queries,other
145+
- contains:
146+
path: spec.template.spec.containers[0].env
147+
content:
148+
name: CELERY_WORKER_CONCURRENCY
149+
value: "50"
150+
- contains:
151+
path: spec.template.spec.containers[0].env
152+
content:
153+
name: CELERY_WORKER_POOL
154+
value: gevent

0 commit comments

Comments
 (0)