Skip to content
This repository was archived by the owner on Aug 29, 2020. It is now read-only.

Commit dba451e

Browse files
committed
Remove label checks
1 parent 7a5a2fb commit dba451e

File tree

2 files changed

+8
-64
lines changed

2 files changed

+8
-64
lines changed

src/Compiler/ReleaseNotesBuilder.cs

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System;
22
using System.Collections.Generic;
3-
using System.Globalization;
43
using System.IO;
54
using System.Linq;
65
using System.Text;
@@ -36,7 +35,7 @@ public async Task<string> BuildReleaseNotes()
3635
milestones = await gitHubClient.GetMilestones();
3736

3837
GetTargetMilestone();
39-
var issues = await GetIssues(targetMilestone);
38+
var issues = await gitHubClient.GetIssues(targetMilestone);
4039
var stringBuilder = new StringBuilder();
4140
var previousMilestone = GetPreviousMilestone();
4241
var numberOfCommits = await gitHubClient.GetNumberOfCommitsBetween(previousMilestone, targetMilestone);
@@ -122,31 +121,6 @@ static async Task AddFooter(StringBuilder stringBuilder)
122121
}
123122
}
124123

125-
126-
async Task<List<Issue>> GetIssues(Milestone milestone)
127-
{
128-
var issues = await gitHubClient.GetIssues(milestone);
129-
foreach (var issue in issues)
130-
{
131-
CheckForValidLabels(issue);
132-
}
133-
return issues;
134-
}
135-
136-
static void CheckForValidLabels(Issue issue)
137-
{
138-
if (issue.Labels.Count(label => label.Name.StartsWith(LabelPrefix)) != 1)
139-
{
140-
var message = string.Format(
141-
CultureInfo.CurrentCulture,
142-
"Bad issue {0}. Expected to find a single label starting with '{1}'.",
143-
issue.HtmlUrl,
144-
LabelPrefix);
145-
146-
throw new InvalidOperationException(message);
147-
}
148-
}
149-
150124
void Append(IEnumerable<Issue> issues, string labelName, StringBuilder builder)
151125
{
152126
var relevantIssues = issues
Lines changed: 7 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,25 @@
11
namespace ReleaseNotesCompiler.Tests
22
{
3-
using System.Diagnostics;
3+
using System;
44
using System.Threading.Tasks;
55
using NUnit.Framework;
66
using ReleaseNotesCompiler;
77

88
[TestFixture]
99
public class ReleaseNotesBuilderIntegrationTests
1010
{
11-
[Test]
1211
[Explicit]
13-
public async Task SingleMilestone()
12+
[TestCase("NServiceBus", "5.1.0")]
13+
[TestCase("ServiceControl", "1.0.0-Beta4")]
14+
[TestCase("NServiceBus", "6.0.0")]
15+
public async Task CoreVersion6(string repo, string version)
1416
{
1517
var gitHubClient = ClientBuilder.Build();
1618

17-
var releaseNotesBuilder = new ReleaseNotesBuilder(new DefaultGitHubClient(gitHubClient, "Particular", "NServiceBus"), "Particular", "NServiceBus", "5.1.0");
19+
var releaseNotesBuilder = new ReleaseNotesBuilder(new DefaultGitHubClient(gitHubClient, "Particular", repo), "Particular", repo, version);
1820
var result = await releaseNotesBuilder.BuildReleaseNotes();
19-
Debug.WriteLine(result);
21+
Console.WriteLine(result);
2022
ClipBoardHelper.SetClipboard(result);
2123
}
22-
23-
[Test]
24-
[Explicit]
25-
public async Task SingleMilestone3()
26-
{
27-
var gitHubClient = ClientBuilder.Build();
28-
29-
var releaseNotesBuilder = new ReleaseNotesBuilder(new DefaultGitHubClient(gitHubClient, "Particular", "ServiceControl"), "Particular", "ServiceControl", "1.0.0-Beta4");
30-
var result = await releaseNotesBuilder.BuildReleaseNotes();
31-
Debug.WriteLine(result);
32-
ClipBoardHelper.SetClipboard(result);
33-
}
34-
35-
36-
[Test]
37-
[Explicit]
38-
public async Task CoreVersion6()
39-
{
40-
var gitHubClient = ClientBuilder.Build();
41-
42-
var releaseNotesBuilder = new ReleaseNotesBuilder(new DefaultGitHubClient(gitHubClient, "Particular", "NServiceBus"), "Particular", "NServiceBus", "6.0.0");
43-
var result = await releaseNotesBuilder.BuildReleaseNotes();
44-
Debug.WriteLine(result);
45-
ClipBoardHelper.SetClipboard(result);
46-
}
47-
48-
[Test]
49-
[Explicit]
50-
public void OctokitTests()
51-
{
52-
ClientBuilder.Build();
53-
}
5424
}
5525
}

0 commit comments

Comments
 (0)