Skip to content

Fix ending slash bugs. #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2017
Merged

Fix ending slash bugs. #513

merged 2 commits into from
Dec 5, 2017

Conversation

@gongweibao
Copy link
Collaborator

Fix #512
typhoonzero
typhoonzero requested changes Dec 5, 2017
View reviewed changes
go/utils/config/config.go
return nil
}

var re = regexp.MustCompile(`(/|\\)*$`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex is slow, why not simply remove the trailing slash. By the way, can you add a verify of the endpoint string to ensure it is an URL?
Copy link
Collaborator Author

@gongweibao gongweibao Dec 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The user's input is diverse and only a few strings are checked once.
  2. Done!
Yancey0623
Yancey0623 approved these changes Dec 5, 2017
View reviewed changes
Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++
@gongweibao gongweibao merged commit 3b12aac into PaddlePaddle:develop Dec 5, 2017
@gongweibao gongweibao deleted the rmendslash branch December 5, 2017 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@gongweibao @Yancey0623 @typhoonzero