Skip to content

Conversation

@gongweibao
Copy link
Collaborator

@gongweibao gongweibao commented Jul 7, 2017

@gongweibao gongweibao changed the title Don't merge!Just test! Add cloud pre-commit. Jul 7, 2017
typhoonzero
typhoonzero previously approved these changes Jul 11, 2017
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++ except one comment.

@@ -0,0 +1,20 @@
#!/bin/bash
function abort(){
echo "Your change doesn't follow PaddlePaddle's code style." 1>&2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PaddlePaddle => PaddleCloud

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit b00a1f6 into PaddlePaddle:develop Jul 11, 2017
@gongweibao gongweibao deleted the goprecommit branch August 21, 2017 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants