Upload files with recursion #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
typhoonzero reviewed Jul 3, 2017
go/paddlecloud/simplefile.go Outdated
| } | ||
| for _, file := range files { | ||
| _, fn := path.Split(file.Name()) | ||
| putFiles(path.Join(src, fn), path.Join(dest, fn)) |
There was a problem hiding this comment.
Can use os.Walk to prevent large recursive calls.
There was a problem hiding this comment.
You mean the filepath.Walk? It will list all the sub-files for the given directory, but I want to list the files hierarchy by hierarchy.
There was a problem hiding this comment.
So what's the difference? We want to upload them anyway.
There was a problem hiding this comment.
Modify the code to un-recursion.
Done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed #192