Skip to content

Support registry resource #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2017
Merged

Support registry resource #154

merged 5 commits into from
Jun 22, 2017

Conversation

@Yancey0623
Copy link
Collaborator

@Yancey0623 Yancey0623 commented Jun 19, 2017 •
edited
Loading

  • Add registry: paddlecloud registry --name test --username test --password test --server x.y.z
  • Delete registry: paddlecloud delete registry ${registry-name}
  • List registry: paddlecloud get registry

Fixed #140
@Yancey0623 Yancey0623 requested a review from typhoonzero June 19, 2017 11:27
@Yancey0623 Yancey0623 changed the title Add registry resource Support registry resource Jun 19, 2017
typhoonzero
typhoonzero requested changes Jun 19, 2017
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add docs in doc/usage_cn.md
go/cmd/paddlecloud/paddlecloud.go
subcommands.Register(&pfsmod.MkdirCmd{}, "")
subcommands.Register(&paddlecloud.RegistryCmd{}, "")
subcommands.Register(&paddlecloud.DeleteCommand{}, "")
subcommands.Register(&pfsmod.LsCmd{}, "PFS")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the second argument "PFS" mean?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second argument of subcommands.Register is group, if we add a subcommand with a specify a group name, these subcommands will be explained with a group name before, such as:

Subcommands:	commands list all command names	delete Delete the specify resource.	file Simple file operations. ... Subcommands for PFS:	cp uoload or download files	ls List files on PaddlePaddle Cloud ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
typhoonzero
typhoonzero previously approved these changes Jun 22, 2017
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still, commands like paddlecloud registry ... means add, but there's no verb in this command
@Yancey0623 Yancey0623 merged commit 5024db6 into PaddlePaddle:develop Jun 22, 2017
@Yancey0623 Yancey0623 deleted the add_secret branch June 22, 2017 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Yancey0623 @typhoonzero