add testcase #144
Merged
add testcase #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
typhoonzero requested changes Jun 15, 2017
.tools/gen_config.sh Outdated
| cat > ~/.paddle/config << EOF | ||
| datacenters: | ||
| - name: datacenter1 | ||
| username: gongweibao@baidu.com |
There was a problem hiding this comment.
Do not use actual usernames.
helinwang reviewed Jun 21, 2017
| @@ -0,0 +1,10 @@ | |||
| #/bin/bash | |||
| mkdir -p ~/.paddle | |||
There was a problem hiding this comment.
Maybe instead of generating this file with a script (unit test breaks without running this script), you can check in this file into the code base, maybe under testdata, like:https://github.com/golang/go/blob/master/src/net/testdata/hosts . And add argument to override the default location ~/.paddle to the test file.
There was a problem hiding this comment.
config是一个全局变量，这个参数不太好覆盖。如果不用这个全局变量，需要改动的地方太多。这个能否后续再想想如何更简单的解决这问题？
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #156
Add test case of
lschunkmetacp.