Skip to content

Conversation

@ApricityXX
Copy link
Contributor

@ApricityXX ApricityXX commented Jun 9, 2025

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

修复openfile未检查的bug共1处
调用函数[open]打开资源,赋值给[out_fd],未判断资源[out_fd]状态是否可用的情况下就调用函数[close]关闭资源[out_fd],可能造成系统错误。

@paddle-bot
Copy link

paddle-bot bot commented Jun 9, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jun 9, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (develop@a43bff6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/fluid/inference/utils/io_utils.cc 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #73211 +/- ## ========================================== Coverage ? 50.00% ========================================== Files ? 1 Lines ? 2 Branches ? 0 ========================================== Hits ? 1 Misses ? 1 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 10, 2025
@luotao1
Copy link
Contributor

luotao1 commented Jun 10, 2025

修复openfile未检查的bug共1处

PR描述里请详细描述下bug

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Jun 10, 2025
@ApricityXX
Copy link
Contributor Author

修复openfile未检查的bug共1处

PR描述里请详细描述下bug

姐可以check下这条pr了

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 1419307 into PaddlePaddle:develop Jun 12, 2025
72 of 74 checks passed
shanjiang7 pushed a commit to shanjiang7/Paddle that referenced this pull request Jun 12, 2025
@luotao1 luotao1 added Beijing Innovation Consortium and removed HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 labels Sep 18, 2025
@luotao1 luotao1 changed the title Fix openfile_check bug 1st-batch-46-Fix openfile_check bug Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants