fix tensordot #72139
Merged
fix tensordot #72139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
12 tasks
Comment on lines +6013 to +6016
| y = y.sum(dim_y, dtype=y.dtype).reshape(shape_y) | ||
| elif sy == 1: | ||
| shape_x[dim_x] = 1 | ||
| x = x.sum(dim_x).reshape(shape_x) | ||
| x = x.sum(dim_x, dtype=x.dtype).reshape(shape_x) |
There was a problem hiding this comment.
这里的逻辑应该是中间结果用int64存，然后最终结果转成int32，还是保持中间结果也是int32？如果输入中含有接近int32最大值的场景，哪一种比较合适呢？可以跟numpy或者torch对比一下这种场景下的数值溢出情况
There was a problem hiding this comment.
这个修改的意图是明确指定 sum 操作的输出数据类型与其输入数据类型保持一致。溢出这一块应该是由开发者处理，框架应该保证正确性（未指定dtype，输入int32，输出int32）
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
* update * add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
当输入都为int32时，输出会是int64。