Skip to content

Commit db11357

Browse files
authored
[Approver Update] update check approver of qili93, test=document_fix (#39483)
1 parent 9722994 commit db11357

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tools/check_file_diff_approvals.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ for API_FILE in ${API_FILES[*]}; do
179179
echo_line="You must have one RD (Xreki,luotao1,zhhsplendid) approval for ${API_FILE}, which manages the underlying code for PaddlePaddle.\n"
180180
check_approval 1 12538138 6836917 7913861
181181
else
182-
echo_line="You must have one RD (XiaoguangHu01,chenwhql,zhiqiu,Xreki,luotao1) approval for ${API_FILE}, which manages the underlying code for fluid.\n"
183-
check_approval 1 46782768 12538138 6836917 22561442 6888866
182+
echo_line="You must have one RD (XiaoguangHu01,chenwhql,zhiqiu,Xreki,luotao1,qili93) approval for ${API_FILE}, which manages the underlying code for fluid.\n"
183+
check_approval 1 46782768 12538138 6836917 22561442 6888866 16605440
184184
fi
185185
fi
186186
done
@@ -288,8 +288,8 @@ fi
288288

289289
HAS_OPERATORBASE_FLAG=`git diff -U0 --diff-filter=A upstream/$BRANCH | grep -E "public[[:space:]]+.*OperatorBase" || true`
290290
if [ "${HAS_OPERATORBASE_FLAG}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
291-
echo_line="In order to support dynamic graph, all ops are not recommended to inherit OperatorBase. Please use OperatorWithKernel instead.\nYou must have one RD (phlrain (Recommend), luotao1, lanxianghit or XiaoguangHu01) approval for the inherit of OperatorBase.\nYou inherit the OperatorBase class. The corresponding lines are as follows:\n${HAS_OPERATORBASE_FLAG}"
292-
check_approval 1 43953930 6836917 47554610 46782768
291+
echo_line="In order to support dynamic graph, all ops are not recommended to inherit OperatorBase. Please use OperatorWithKernel instead.\nYou must have one RD (phlrain (Recommend), luotao1, lanxianghit, XiaoguangHu01, or qili93) approval for the inherit of OperatorBase.\nYou inherit the OperatorBase class. The corresponding lines are as follows:\n${HAS_OPERATORBASE_FLAG}"
292+
check_approval 1 43953930 6836917 47554610 46782768 16605440
293293
fi
294294

295295
HAS_INPLACE_TESTS=`git diff -U0 upstream/$BRANCH |grep "+" |grep -E "inplace_atol[[:space:]]*=.*" || true`

0 commit comments

Comments
 (0)