Skip tests when 'git' command is not available

This change is intended to be a quick-fix to allow the test suite to pass. A later enhancement would be to move this check to happen at runtime so that if a user attempts to use one of these affected filters, a suitable error message and exit code can be used. When that happens, the tests will need to be reworked to cover that functionality.

Author: fredden

tests/Core/Filters/AbstractFilterTestCase.php

@@ -247,4 +247,30 @@ protected static function mapPathsToRuntimeOs(array $paths)
  }//end mapPathsToRuntimeOs()
 
 
+ /**
+ * Mark the current test as 'skipped' if the 'git' command-line tool is not available.
+ *
+ * @return void
+ */
+ protected function checkGitCommandAvailable()
+ {
+ static $result = null;
+
+ if (is_bool($result) === false) {
+ if (strpos(PHP_OS, 'WIN') === 0) {
+ $test = 'where';
+ } else {
+ $test = 'command -v';
+ }
+
+ $result = is_executable(trim((string) shell_exec("$test git")));
+ }
+
+ if ($result === false) {
+ $this->markTestSkipped('git command not available');
+ }
+
+ }//end checkGitCommandAvailable()
+
+
 }//end class

tests/Core/Filters/GitModifiedTest.php

@@ -219,6 +219,8 @@ public function testExecAlwaysReturnsArray($cmd, $expected)
  $this->markTestSkipped('Not a git repository');
  }
 
+ $this->checkGitCommandAvailable();
+
  $fakeDI = new RecursiveArrayIterator(self::getFakeFileList());
  $filter = new GitModified($fakeDI, '/', self::$config, self::$ruleset);
 

tests/Core/Filters/GitStagedTest.php

@@ -219,6 +219,8 @@ public function testExecAlwaysReturnsArray($cmd, $expected)
  $this->markTestSkipped('Not a git repository');
  }
 
+ $this->checkGitCommandAvailable();
+
  $fakeDI = new RecursiveArrayIterator(self::getFakeFileList());
  $filter = new GitStaged($fakeDI, '/', self::$config, self::$ruleset);