Merge pull request #695 from PHPCSStandards/feature/fix-test-runtime-deprecations-php-8.5

PHP 8.5 | TestUtils: prevent deprecation notice for Reflection*::setAccessible()

Author: jrfnl

PHPCSUtils/TestUtils/ConfigDouble.php

@@ -211,7 +211,7 @@ private function preventAutoDiscoveryScreenWidth()
  public function getStaticConfigProperty($name)
  {
  $property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
 
  if ($name === 'overriddenDefaults' && \version_compare($this->phpcsVersion, '3.99.99', '>')) {
  return $property->getValue($this);
@@ -236,14 +236,14 @@ public function getStaticConfigProperty($name)
  public function setStaticConfigProperty($name, $value)
  {
  $property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
 
  if ($name === 'overriddenDefaults' && \version_compare($this->phpcsVersion, '3.99.99', '>')) {
  $property->setValue($this, $value);
  } else {
  $property->setValue(null, $value);
  }
 
- $property->setAccessible(false);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
  }
 }

PHPCSUtils/TestUtils/UtilityMethodTestCase.php

@@ -349,9 +349,9 @@ public static function resetTestFile()
  public static function setStaticConfigProperty($name, $value)
  {
  $property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
  $property->setValue(null, $value);
- $property->setAccessible(false);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
  }
 
  /**

Tests/AssertPropertySame.php

@@ -78,9 +78,9 @@ public static function getObjectPropertyValue($objectUnderTest, $propertyName)
  return $objectUnderTest->$propertyName;
  }
 
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
  $value = $property->getValue($objectUnderTest);
- $property->setAccessible(false);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
 
  return $value;
  } catch (ReflectionException $e) {

Tests/TestUtils/ConfigDouble/ConfigDoubleTest.php

@@ -300,7 +300,7 @@ public function testDestruct()
  private function getStaticConfigProperty($name, $config = null)
  {
  $property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
 
  if ($name === 'overriddenDefaults' && \version_compare(Helper::getVersion(), '3.99.99', '>')) {
  // The `overriddenDefaults` property is no longer static on PHPCS 4.0+.
@@ -330,8 +330,8 @@ public static function setStaticConfigProperty($name, $value)
  }
 
  $property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
  $property->setValue(null, $value);
- $property->setAccessible(false);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(false);
  }
 }

Tests/TestUtils/UtilityMethodTestCase/ResetTestFileTest.php

@@ -183,7 +183,7 @@ public function testTearDownCleansUpStaticConfigProperties()
  private function getStaticConfigProperty($name, $config = null)
  {
  $property = new ReflectionProperty('PHP_CodeSniffer\Config', $name);
- $property->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $property->setAccessible(true);
 
  if ($name === 'overriddenDefaults'
  && (self::$phpcsVersion === '0' || \version_compare(self::$phpcsVersion, '3.99.99', '>'))

Tests/Tokens/Collections/PropertyBasedTokenArraysTest.php

@@ -36,9 +36,9 @@ final class PropertyBasedTokenArraysTest extends TestCase
  public function testPropertyBasedTokenArrays($name)
  {
  $reflProp = new ReflectionProperty('PHPCSUtils\Tokens\Collections', $name);
- $reflProp->setAccessible(true);
+ (\PHP_VERSION_ID < 80100) && $reflProp->setAccessible(true);
  $expected = $reflProp->getValue();
- $reflProp->setAccessible(false);
+ (\PHP_VERSION_ID < 80100) && $reflProp->setAccessible(false);
 
  $this->assertSame($expected, Collections::$name());
  }