Merge pull request #195 from PHPCSStandards/phpcs-4.x/t_use-parenthesis-owner-initial-changes

PHPCS 4.x | Initial updates to handle T_USE becoming a parentheses owner

Author: jrfnl

PHPCSUtils/Utils/Operators.php

@@ -124,7 +124,10 @@ public static function isReference(File $phpcsFile, $stackPtr)
  if ($lastOpener !== false) {
  $lastOwner = Parentheses::getOwner($phpcsFile, $lastOpener);
 
- if (isset(Collections::functionDeclarationTokensBC()[$tokens[$lastOwner]['code']]) === true) {
+ if (isset(Collections::functionDeclarationTokensBC()[$tokens[$lastOwner]['code']]) === true
+ // As of PHPCS 4.x, `T_USE` is a parenthesis owner.
+ || $tokens[$lastOwner]['code'] === \T_USE
+ ) {
  $params = FunctionDeclarations::getParameters($phpcsFile, $lastOwner);
  foreach ($params as $param) {
  if ($param['reference_token'] === $stackPtr) {

Tests/BackCompat/BCTokens/ParenthesisOpenersTest.php

@@ -12,6 +12,7 @@
 
 use PHP_CodeSniffer\Util\Tokens;
 use PHPCSUtils\BackCompat\BCTokens;
+use PHPCSUtils\BackCompat\Helper;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -33,6 +34,7 @@ class ParenthesisOpenersTest extends TestCase
  */
  public function testParenthesisOpeners()
  {
+ $version = Helper::getVersion();
  $expected = [
  \T_ARRAY => \T_ARRAY,
  \T_LIST => \T_LIST,
@@ -49,6 +51,10 @@ public function testParenthesisOpeners()
  \T_DECLARE => \T_DECLARE,
  ];
 
+ if (\version_compare($version, '4.0.0', '>=') === true) {
+ $expected[\T_USE] = \T_USE;
+ }
+
  \asort($expected);
 
  $result = BCTokens::parenthesisOpeners();