Skip to content

Conversation

@Adnan-Sabic
Copy link
Contributor

Made the generator generate pub property for Object model.
fix: #22143

@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit 
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@wing328
Copy link
Member

wing328 commented Oct 15, 2025

please update the samples too by running:

./bin/generate-samples.sh ./bin/configs/manual/rust-axum-* 

cc @linxGnu

@linxGnu
Copy link
Contributor

linxGnu commented Oct 16, 2025

Hi @Adnan-Sabic
Thank you for making the PR. It's LGTM.

Could you please explain more about your motivation in the ticket description, for example: accessibility from other crate. Btw, I prefer impl AsRef + constructor for this case.

@linxGnu
Copy link
Contributor

linxGnu commented Oct 16, 2025

@wing328 I think we can merge this PR.

@Adnan-Sabic
Copy link
Contributor Author

Hi @Adnan-Sabic Thank you for making the PR. It's LGTM.

Could you please explain more about your motivation in the ticket description, for example: accessibility from other crate. Btw, I prefer impl AsRef + constructor for this case.

I guess u found the answer in the fix: #22143, thanks for the review.

@wing328 wing328 merged commit fc12a1b into OpenAPITools:master Oct 16, 2025
16 of 18 checks passed
@wing328 wing328 added this to the 7.17.0 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment