Skip to content

Conversation

@toriumi0118
Copy link
Contributor

@toriumi0118 toriumi0118 commented Sep 14, 2023

to fix #16261

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh 
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date 
    Commit all changed files.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
wing328 added a commit that referenced this pull request Jul 10, 2024
* fix: issue 16261. JsonObject is missing on a generated code * update samples --------- Co-authored-by: toriumi0118 <toriumi0118@gmail.com>
@wing328
Copy link
Member

wing328 commented Jul 10, 2024

closed via #19130

@wing328 wing328 closed this Jul 10, 2024
@wing328 wing328 changed the title [dart-dio] fix: issue 16261. JsonObject is missing on a generated code [dart-dio] fix JsonObject is missing on a generated code Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants