Skip to content

Commit b128d14

Browse files
authored
[scala-httpclient] mark the generator as deprecated (#2357)
* deprecate scala-httpclient * update doc
1 parent 3ba6d82 commit b128d14

File tree

5 files changed

+27
-4
lines changed

5 files changed

+27
-4
lines changed

bin/scala-httpclient-petstore.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ fi
2727

2828
# if you've executed sbt assembly previously it will use that instead.
2929
export JAVA_OPTS="${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties"
30-
ags="generate -t modules/openapi-generator/src/main/resources/scala-httpclient -i modules/openapi-generator/src/test/resources/2_0/petstore.yaml -g scala-httpclient -o samples/client/petstore/scala-httpclient $@"
30+
ags="generate -t modules/openapi-generator/src/main/resources/scala-httpclient -i modules/openapi-generator/src/test/resources/2_0/petstore.yaml -g scala-httpclient-deprecated -o samples/client/petstore/scala-httpclient $@"
3131

3232
java $JAVA_OPTS -jar $executable $ags

bin/windows/scala-httpclient-petstore.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ If Not Exist %executable% (
55
)
66

77
REM set JAVA_OPTS=%JAVA_OPTS% -Xmx1024M
8-
set ags=generate -i modules\openapi-generator\src\test\resources\2_0\petstore.yaml -g scala-httpclient -o samples\client\petstore\scala-httpclient
8+
set ags=generate -i modules\openapi-generator\src\test\resources\2_0\petstore.yaml -g scala-httpclient-deprecated -o samples\client\petstore\scala-httpclient
99

1010
java %JAVA_OPTS% -jar %executable% %ags%

docs/generators.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The following generators are available:
4747
- [rust](generators/rust.md)
4848
- [scala-akka](generators/scala-akka.md)
4949
- [scala-gatling](generators/scala-gatling.md)
50-
- [scala-httpclient](generators/scala-httpclient.md)
50+
- [scala-httpclient-deprecated](generators/scala-httpclient-deprecated.md)
5151
- [scalaz](generators/scalaz.md)
5252
- [swift2-deprecated](generators/swift2-deprecated.md)
5353
- [swift3-deprecated](generators/swift3-deprecated.md)
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
2+
---
3+
id: generator-opts-client-scala-httpclient-deprecated
4+
title: Config Options for scala-httpclient-deprecated
5+
sidebar_label: scala-httpclient-deprecated
6+
---
7+
8+
| Option | Description | Values | Default |
9+
| ------ | ----------- | ------ | ------- |
10+
|sortParamsByRequiredFlag|Sort method arguments to place required parameters before optional parameters.| |true|
11+
|ensureUniqueParams|Whether to ensure parameter names are unique in an operation (rename parameters that are not).| |true|
12+
|allowUnicodeIdentifiers|boolean, toggles whether unicode identifiers are allowed in names or not, default is false| |false|
13+
|prependFormOrBodyParameters|Add form or body parameters to the beginning of the parameter list.| |false|
14+
|modelPackage|package for generated models| |null|
15+
|apiPackage|package for generated api classes| |null|
16+
|sourceFolder|source folder for generated code| |null|
17+
|modelPropertyNaming|Naming convention for the property: 'camelCase', 'PascalCase', 'snake_case' and 'original', which keeps the original name| |camelCase|

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ScalaHttpClientCodegen.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@
2929
import static org.openapitools.codegen.utils.StringUtils.camelize;
3030
import static org.openapitools.codegen.utils.StringUtils.underscore;
3131

32+
/*
33+
* This generator has been deprecated. Please use scala-akka instead.
34+
*/
3235
public class ScalaHttpClientCodegen extends AbstractScalaCodegen implements CodegenConfig {
3336
private static final Logger LOGGER = LoggerFactory.getLogger(ScalaHttpClientCodegen.class);
3437

@@ -131,6 +134,9 @@ public ScalaHttpClientCodegen() {
131134

132135
@Override
133136
public void processOpts() {
137+
LOGGER.warn("IMPORTANT: This generator (scala-http-client-deprecated) is no longer actively maintained and will be deprecated. " +
138+
"PLease use 'scala-akka' generator instead.");
139+
134140
super.processOpts();
135141
if (additionalProperties.containsKey(CodegenConstants.MODEL_PROPERTY_NAMING)) {
136142
setModelPropertyNaming((String) additionalProperties.get(CodegenConstants.MODEL_PROPERTY_NAMING));
@@ -207,7 +213,7 @@ public CodegenType getTag() {
207213

208214
@Override
209215
public String getName() {
210-
return "scala-httpclient";
216+
return "scala-httpclient-deprecated";
211217
}
212218

213219
@Override

0 commit comments

Comments
 (0)