Reduces time wasted in when using a native driver

UrlChecker normally adds 1 second to any test that creates and destroys a DriverService such as the ChromeDriver since the initial poll on both startup and shutdown nearly always fails and the time between polls (500 millis) is high. This switches to using an initially small but exponentially increasing poll time in order to waste much less time waiting for nothing. Closes SeleniumHQ#1334 Signed-off-by: Luke Inman-Semerau <luke.semerau@gmail.com>

Author: Mahoney

java/client/src/org/openqa/selenium/net/UrlChecker.java

@@ -48,7 +48,8 @@ public class UrlChecker {
 
  private static final int CONNECT_TIMEOUT_MS = 500;
  private static final int READ_TIMEOUT_MS = 1000;
- private static final long POLL_INTERVAL_MS = 500;
+ private static final long MAX_POLL_INTERVAL_MS = 320;
+ private static final long MIN_POLL_INTERVAL_MS = 10;
 
  private static final AtomicInteger THREAD_COUNTER = new AtomicInteger(1);
  private static final ExecutorService THREAD_POOL = Executors
@@ -80,6 +81,7 @@ public void waitUntilAvailable(long timeout, TimeUnit unit, final URL... urls)
  public Void call() throws InterruptedException {
  HttpURLConnection connection = null;
 
+ long sleepMillis = MIN_POLL_INTERVAL_MS;
  while (true) {
  for (URL url : urls) {
  try {
@@ -96,7 +98,8 @@ public Void call() throws InterruptedException {
  }
  }
  }
- MILLISECONDS.sleep(POLL_INTERVAL_MS);
+ MILLISECONDS.sleep(sleepMillis);
+ sleepMillis = (sleepMillis >= MAX_POLL_INTERVAL_MS) ? sleepMillis : sleepMillis * 2;
  }
  }
  }, timeout, unit, true);
@@ -118,6 +121,7 @@ public void waitUntilUnavailable(long timeout, TimeUnit unit, final URL url)
  public Void call() throws InterruptedException {
  HttpURLConnection connection = null;
 
+ long sleepMillis = MIN_POLL_INTERVAL_MS;
  while (true) {
  try {
  log.fine("Polling " + url);
@@ -133,7 +137,8 @@ public Void call() throws InterruptedException {
  }
  }
 
- MILLISECONDS.sleep(POLL_INTERVAL_MS);
+ MILLISECONDS.sleep(sleepMillis);
+ sleepMillis = (sleepMillis >= MAX_POLL_INTERVAL_MS) ? sleepMillis : sleepMillis * 2;
  }
  }
  }, timeout, unit, true);

java/client/test/org/openqa/selenium/net/UrlCheckerTest.java

@@ -0,0 +1,118 @@
+// Licensed to the Software Freedom Conservancy (SFC) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The SFC licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.openqa.selenium.net;
+
+import static java.lang.System.currentTimeMillis;
+import static org.hamcrest.Matchers.lessThan;
+import static org.junit.Assert.assertThat;
+import static org.openqa.selenium.net.PortProber.findFreePort;
+
+import org.junit.After;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.seleniumhq.jetty9.server.Handler;
+import org.seleniumhq.jetty9.server.HttpConnection;
+import org.seleniumhq.jetty9.server.Request;
+import org.seleniumhq.jetty9.server.Server;
+import org.seleniumhq.jetty9.server.ServerConnector;
+import org.seleniumhq.jetty9.server.handler.AbstractHandler;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+@RunWith(JUnit4.class)
+public class UrlCheckerTest {
+
+ private final UrlChecker urlChecker = new UrlChecker();
+ int port = findFreePort();
+ Server server = buildServer();
+
+ private Server buildServer() {
+ Server server = new Server(port);
+ server.setHandler(new AbstractHandler() {
+ @Override
+ public void handle(String s, Request request, HttpServletRequest httpServletRequest,
+ HttpServletResponse httpServletResponse)
+ throws IOException, ServletException {
+ httpServletResponse.setStatus(200);
+ httpServletResponse.getWriter().println("<h1>Working</h1>");
+ request.setHandled(true);
+ }
+ });
+ return server;
+ }
+
+ ExecutorService executorService = Executors.newSingleThreadExecutor();
+
+ @Test
+ public void testWaitUntilAvailableIsTimely() throws Exception {
+
+ executorService.submit(new Callable<Object>() {
+ @Override
+ public Object call() throws Exception {
+ Thread.sleep(10L);
+ server.start();
+ return null;
+ }
+ });
+
+ long start = currentTimeMillis();
+ urlChecker.waitUntilAvailable(10, TimeUnit.SECONDS, new URL("http://localhost:" + port + "/"));
+ long elapsed = currentTimeMillis() - start;
+ assertThat(elapsed, lessThan(450L));
+ System.out.println(elapsed);
+ }
+
+ @Test
+ public void testWaitUntilUnavailableIsTimely() throws Exception {
+
+ server.start();
+ urlChecker.waitUntilAvailable(10, TimeUnit.SECONDS, new URL("http://localhost:" + port + "/"));
+
+ executorService.submit(new Callable<Object>() {
+ @Override
+ public Object call() throws Exception {
+ Thread.sleep(10L);
+ server.stop();
+ return null;
+ }
+ });
+
+ long start = currentTimeMillis();
+ urlChecker.waitUntilUnavailable(10, TimeUnit.SECONDS,
+ new URL("http://localhost:" + port + "/"));
+ long elapsed = currentTimeMillis() - start;
+ assertThat(elapsed, lessThan(450L));
+ System.out.println(elapsed);
+ }
+
+ @After
+ public void cleanup() throws Exception {
+ server.stop();
+ server.join();
+ executorService.shutdown();
+ }
+}