Exposing session ID property on RemoteWebDriver in .NET bindings

Users can now cast their driver instance to IHasSessionId to access the SessionId property, which returns a SessionId object. To use the SessionId object with external tools, simply call the ToString() method on the instance. Note that relying on the SessionId for anything is probably a Bad Thing, because it introduces a leak in the abstraction of a driver. Please do not use this property; its introduction is the Wrong Approach, but it's being exposed at the insistence of a selection of users.

Author: jimevans

dotnet/src/webdriver/Remote/IHasSessionId.cs

@@ -0,0 +1,18 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace OpenQA.Selenium.Remote
+{
+ /// <summary>
+ /// Interface indicating the driver has a Session ID.
+ /// </summary>
+ public interface IHasSessionId
+ {
+ /// <summary>
+ /// Gets the session ID of the current session.
+ /// </summary>
+ SessionId SessionId { get; }
+ }
+}

dotnet/src/webdriver/Remote/RemoteWebDriver.cs

@@ -60,7 +60,7 @@ namespace OpenQA.Selenium.Remote
  /// }
  /// </code>
  /// </example>
- public class RemoteWebDriver : IWebDriver, ISearchContext, IJavaScriptExecutor, IFindsById, IFindsByClassName, IFindsByLinkText, IFindsByName, IFindsByTagName, IFindsByXPath, IFindsByPartialLinkText, IFindsByCssSelector, ITakesScreenshot, IHasInputDevices, IHasCapabilities, IHasWebStorage, IHasLocationContext, IHasApplicationCache, IAllowsFileDetection
+ public class RemoteWebDriver : IWebDriver, ISearchContext, IJavaScriptExecutor, IFindsById, IFindsByClassName, IFindsByLinkText, IFindsByName, IFindsByTagName, IFindsByXPath, IFindsByPartialLinkText, IFindsByCssSelector, ITakesScreenshot, IHasInputDevices, IHasCapabilities, IHasWebStorage, IHasLocationContext, IHasApplicationCache, IAllowsFileDetection, IHasSessionId
  {
  /// <summary>
  /// The default command timeout for HTTP requests in a RemoteWebDriver instance.
@@ -392,6 +392,14 @@ public virtual IFileDetector FileDetector
  }
  }
 
+ /// <summary>
+ /// Gets the <see cref="SessionId"/> for the current session of this driver.
+ /// </summary>
+ public SessionId SessionId
+ {
+ get { return this.sessionId; }
+ }
+
  /// <summary>
  /// Gets a value indicating whether or not the driver is compliant with the W3C WebDriver specification.
  /// </summary>
@@ -408,14 +416,6 @@ protected ICommandExecutor CommandExecutor
  get { return this.executor; }
  }
 
- /// <summary>
- /// Gets the <see cref="SessionId"/> for the current session of this driver.
- /// </summary>
- protected SessionId SessionId
- {
- get { return this.sessionId; }
- }
-
  /// <summary>
  /// Finds the first element in the page that matches the <see cref="By"/> object
  /// </summary>

dotnet/src/webdriver/WebDriver.csproj

@@ -102,6 +102,7 @@
  <Compile Include="IE\InternetExplorerDriverEngine.cs" />
  <Compile Include="IFileDetector.cs" />
  <Compile Include="Html5\IHasLocationContext.cs" />
+ <Compile Include="Remote\IHasSessionId.cs" />
  <Compile Include="IHasTouchScreen.cs" />
  <Compile Include="Interactions\ScreenMoveAction.cs" />
  <Compile Include="Interactions\ScreenReleaseAction.cs" />