feat: Angular 20 #151
Merged
feat: Angular 20 #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
edusperoni requested changes May 20, 2025
Collaborator
edusperoni left a comment
edusperoni left a comment There was a problem hiding this comment.
added these comments as a guideline (I'll take care of them)
| // if we're skipping ourselves then it's not our responsibility to destroy | ||
| if (typeof flags === 'number') { | ||
| if (!(flags & InjectFlags.SkipSelf) && this.destructibleProviders.has(token)) { | ||
| if (!(flags && this.destructibleProviders.has(token))) { |
Collaborator
There was a problem hiding this comment.
this breaks the skipself flags
Comment on lines 9 to 11
| import { AbortController, AbortSignal } from '@nativescript/core/abortcontroller'; | ||
| (global as any).AbortController = AbortController; | ||
| (global as any).AbortSignal = AbortSignal; |
Collaborator
There was a problem hiding this comment.
should be in the pre-zone polyfills
Contributor Author
There was a problem hiding this comment.
fixed but I'll leave comment in case want to adjust further - they are in pre-zone polyfills now.
No more yarn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.