Skip to content

Conversation

ammarahm-ed
Copy link
Contributor

This pull request includes changes to the MetadataNode::SetInnerTypes method in the test-app/runtime/src/main/cpp/MetadataNode.cpp file to enhance the handling of inner types in V8.

Enhancements to inner type handling:

  • Added a check to determine if a child is already defined as a function before setting it as an accessor. This prevents redefinition when the inner type is a companion object.
  • Fixed the method to properly close the function scope with an additional closing brace.
@ammarahm-ed ammarahm-ed changed the title fix: inner type should net be set when companion object is defined as a property on constructor fix: inner type should not be set when companion object is defined as a property on constructor Feb 20, 2025
@NathanWalker NathanWalker added this to the 8.9 milestone Feb 20, 2025
@NathanWalker NathanWalker merged commit e293636 into NativeScript:main Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants