fix: correctly load ts_helpers.js in workers #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Wouldn't it be better to maybe just add the fields in the configuration objects instead? |
| @edusperoni not sure what you mean. You know the runtime much better than me. If you think there is a better way go for it ! |
| I mean adding on those 2 classes: "DynamicConfiguration" and "StaticConfiguration". I'll take a look later to see how to best refactor it then |
| @farfromrefug there's a build running with this. Can you confirm again if this solves your issues completely and doesn't break anything on your apps? I've simplified it and added tests, so it should be fine. |
| @edusperoni i can confirm this works |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added tests for this, the submodule needs to be update after the merge in the submodule repo