add tests for validate_year updates in aop_download.py

Author: bhass-neon

tests/test_aop_download.py

@@ -25,6 +25,7 @@
 """
 
 # import required packages
+from datetime import datetime
 import os
 import pytest
 import unittest
@@ -120,6 +121,33 @@ def test_invalid_neon_site(self):
  ):
  by_file_aop(dpid=self.dpid, site=invalid_site, year=self.year)
 
+ def test_valid_year(self):
+ # Should not raise for a valid year
+ current_year = datetime.now().year
+ try:
+ by_file_aop(dpid=self.dpid, site=self.site, year=current_year)
+
+ except ValueError:
+ self.fail(
+ "validate_year() raised ValueError unexpectedly for a valid year."
+ )
+
+ def test_invalid_year_out_of_range(self):
+ current_year = datetime.now().year
+ # Should raise for a year before 2012
+ with pytest.raises(
+ ValueError,
+ match=f"2011 is an invalid year. Year must be between 2012 and {current_year}.",
+ ):
+ by_file_aop(dpid=self.dpid, site=self.site, year=2011)
+ # Should raise for a year after the current yearAdd commentMore actions
+ future_year = datetime.now().year + 1
+ with pytest.raises(
+ ValueError,
+ match=f"{future_year} is an invalid year. Year must be between 2012 and {current_year}.",
+ ):
+ by_file_aop(dpid=self.dpid, site=self.site, year=future_year)
+
  @parameterized.expand(
  [
  ("21",),
@@ -132,7 +160,7 @@ def test_invalid_year_format(self, year):
  """
  with pytest.raises(
  ValueError,
- match=f'{year} is an invalid year. Year is required in the format "2017" or 2017, eg. NEON AOP data are available from 2013 to present.',
+ match=f"{year} is an invalid year. Year is required in the format '2017' or 2017, e.g. NEON AOP data are available from 2012 to present.",
  ):
  by_file_aop(dpid=self.dpid, site=self.site, year=year)
 
@@ -336,7 +364,7 @@ def test_invalid_year_format(self, year):
  """
  with pytest.raises(
  ValueError,
- match=f'{year} is an invalid year. Year is required in the format "2017" or 2017, eg. NEON AOP data are available from 2013 to present.',
+ match=f"{year} is an invalid year. Year is required in the format '2017' or 2017, e.g. NEON AOP data are available from 2012 to present.",
  ):
  by_tile_aop(
  dpid=self.dpid,