[pull] master from scop:master #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DeepCode's analysis on #9d827b found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
scop force-pushed the master branch 2 times, most recently from 70248b8 to 2d51900 Compare scop force-pushed the master branch 4 times, most recently from c0e9459 to 09307f8 Compare 
fix: add misc fixes (misc-2)
1. The RequiredRSASize option was added in openssh/openssh-portable@54b333d . 2. RHEL 9.1 changed minimum RSA key size to 2048 by default, broke connections to old SSH servers. 3. Fedora Linux sync'ed the change from RHEL 9.1. See: https://packages.fedoraproject.org/pkgs/openssh/openssh-server/fedora-37.html
The original two xfuncs (exported functions): `_comp_xfunc_apt_cache_{sources,src_packages}` are merged into a single generator interface: `_comp_xfunc_apt_cache_compgen_sources`. The difference of the original two xfuncs seems to have been just the former accepts `cur` (filtering prefix) as an argument while the latter uses variable `cur` in the context. We do not need to prepare such variations for generators because the filtering prefix is externally specified to generators by `_comp_compgen -c cur`. Co-authored-by: Ville Skyttä <ville.skytta@iki.fi> Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
The last character of the variable can be obtained by simply ${var: -1} from bash-2.0, so there is no need to use a helper function to calculate the offset from the variable length. The function is originally introduced in commit 8b23c84 as a function named `__tar_last_char` along with many other functions, but there does not seem to be specific reason for using the function to get the last character of variables. If the command name starts with `-`, `type` is confused and tries to parse it as an option to `type`. In the current setup, the option starting with `-` does not happen because we do not set up the completion settings for such command names, but it is better to put them on a safe side.
This is a regression introduced by commit f2df91d, where `_comp_split` was replaced by `_comp_compgen_split` assuming that the generated words are starting with "$cur". However, we here would like to generate the paths essentially starting with `_path=${cur#*:}` instead of $cur because the caller re-assembles $cur with `-n :`, yet Readline expects the words after `:`. Fixes #1157
fix: use `--` to pass an arbitrary string to builtins
feat: more 3rd party fallback loaders
Rows in `--enghelp` output that contain engine names start with a tab as of fio 3.35. Remove spurious closing parenthesis introduced in commit a1dd4d0.
These values don't take any arguments, so we can keep completing right after them.
feat: more 3rd party fallback completion loaders
fix(scp remote_files): do not filter generated paths with "$cur"
This was missing from the help and man page, but worked for a while.
Leave other punctuation alone, at least for now. Closes #1133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )