Skip to content

Commit b22eacc

Browse files
committed
fix sporadic failures of main.alter_table_online
progress updates aren't deterministic, occasionally they can be skipped (if `LOCK_thd_data` is locked). This isn't a problem as such, but breaks tests that wait for a specific value of the progress (and threads waiting for a specific value of the progress, exactly, lock `LOCK_thd_data` which prevents the progress from being updated) In this particular case, though, there is no need to wait for progress = 100, because "Waiting for table metadata lock" happens only at the end of stage = 4 anyway.
1 parent 1643a25 commit b22eacc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mysql-test/main/alter_table_online.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ send alter table t1 add b int NULL, algorithm= copy, lock= none;
266266
--connection con2
267267
evalp set @con= $con;
268268

269-
let $wait_condition= select stage = 4 and progress = 100
269+
let $wait_condition= select stage = 4
270270
and state= "Waiting for table metadata lock"
271271
from information_schema.processlist where id = @con;
272272
--source include/wait_condition.inc

0 commit comments

Comments
 (0)